All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Brown <sbrown@cortland.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: "John W. Linville" <linville@tuxdriver.com>, linux-mips@linux-mips.org
Subject: Re: ohci-ssb driver on a Broadcom BCM5354
Date: Mon, 26 Nov 2007 06:05:33 -0500	[thread overview]
Message-ID: <474AA87D.7000509@cortland.com> (raw)
In-Reply-To: <200711191923.56471.mb@bu3sch.de>

Michael Buesch wrote:
> On Sunday 18 November 2007 23:47:52 John W. Linville wrote:
>   
>> You probably want to make Michael Buesch aware of this issue.
>>     
>
> I'm not sure anyone really tested this beyond some insmod tests.
> I did not test this, as I don't have such a device.
> So if you have any patches to fix this, please send them. I'm
> certainly the wrong person who can fix this. ;)
>
>   
Adding the following at the end of ssb_ohci_attach seems to fix the problem.

 if (ssb_dma_set_mask(dev, DMA_32BIT_MASK))
   return -EOPNOTSUPP;

I guessed at the dma mask. Would the code in the b43 driver that selects 
a dma mask be appropriate here?

Steve

  reply	other threads:[~2007-11-26 11:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-18 18:23 ohci-ssb driver on a Broadcom BCM5354 Steve Brown
2007-11-18 19:53 ` Franck Bui-Huu
2007-11-18 22:47 ` John W. Linville
2007-11-19 18:23   ` Michael Buesch
2007-11-26 11:05     ` Steve Brown [this message]
2007-11-26 14:15       ` Michael Buesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=474AA87D.7000509@cortland.com \
    --to=sbrown@cortland.com \
    --cc=linux-mips@linux-mips.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.