From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] Add ifdef in irqchip struct for x86 only structures
Date: Mon, 26 Nov 2007 17:19:47 +0200 [thread overview]
Message-ID: <474AE413.2080905@qumranet.com> (raw)
In-Reply-To: <ccf9dd8a8e0a4513090d.1196087633@thinkpad>
Jerone Young wrote:
> # HG changeset patch
> # User Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> # Date 1196087575 21600
> # Node ID ccf9dd8a8e0a4513090d44d52c879fb9dfbb79dd
> # Parent 32d8bd91d9441d2a3655593a0aaf99f6c403d70f
> Add ifdef in irqchip struct for x86 only structures.
>
> This patch fixes a small issue where sturctures:
> kvm_pic_state
> kvm_ioapic_state
>
> are defined inside x86 specific code and may or may not
> be defined in anyway for other architectures. The problem
> caused is one cannot compile userspace apps (ex. libkvm)
> for other archs since a size cannot be determined for these
> structures.
>
>
Applied, but changed
> +#if defined(__i386__) || defined(__x86_64__)
>
to
#ifdef CONFIG_X86
.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2007-11-26 15:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 14:33 [PATCH] Add ifdef in irqchip struct for x86 only structures Jerone Young
2007-11-26 15:19 ` Avi Kivity [this message]
[not found] ` <474AE413.2080905-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-26 16:13 ` Jerone Young
2007-11-26 16:50 ` Avi Kivity
2007-11-26 19:10 ` Anthony Liguori
[not found] ` <474B1A1B.4030104-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-11-27 9:36 ` Zhang, Xiantao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474AE413.2080905@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.