From: Jeff Mahoney <jeffm@suse.com>
To: ReiserFS Mailing List <reiserfs-devel@vger.kernel.org>,
Edward Shishkin <edward@namesys.com>
Subject: [PATCH] reiserfsprogs: remove fsck_sleep
Date: Mon, 26 Nov 2007 17:49:53 -0500 [thread overview]
Message-ID: <474B4D91.9020005@suse.com> (raw)
fsck_sleep causes the file descriptors to be kept open during mount.
Multipath/kpartx doesn't like that.
Realistically, this optimization has always been suspect. It's useless now
that we don't load all the bitmaps on mount.
The previous patch for better fsck -a behavior depends on this one for context.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
utils/fsck/main.c | 17 -----------------
1 file changed, 17 deletions(-)
--- a/utils/fsck/main.c 2007-11-26 17:47:22.000000000 -0500
+++ b/utils/fsck/main.c 2007-11-26 17:47:44.000000000 -0500
@@ -953,21 +953,6 @@ static void clean_attributes (reiserfs_f
}
-/* Do not allow buffers to be flushed after finishing to avoid another bitmap
- * reading on mounting. */
-static void fsck_sleep() {
- int res;
-
- res = fork();
-
- if (res == -1) {
- reiserfs_panic ("reiserfsck: Fork failed: %s", strerror(errno));
- } else if (res == 0) {
- /* Make the child process to sleep for 5 secs. */
- sleep(5);
- }
-}
-
static int auto_check (reiserfs_filsys_t *fs) {
__u16 state;
int retval = 0;
@@ -1034,8 +1019,6 @@ static int auto_check (reiserfs_filsys_t
util_device_dma_fini(fs->fs_dev, &dma_info);
- fsck_sleep();
-
reiserfs_fs_close (fs);
/* do not do anything else. */
exit (EXIT_OK);
--
Jeff Mahoney
SUSE Labs
reply other threads:[~2007-11-26 22:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474B4D91.9020005@suse.com \
--to=jeffm@suse.com \
--cc=edward@namesys.com \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.