All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Emelyanov <xemul@openvz.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Oleg Nesterov <oleg@tv-sign.ru>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/3] start the global /sbin/init with 0,0 special pids
Date: Tue, 27 Nov 2007 18:12:28 +0300	[thread overview]
Message-ID: <474C33DC.7090407@openvz.org> (raw)
In-Reply-To: <m1bq9fk9rh.fsf@ebiederm.dsl.xmission.com>

Eric W. Biederman wrote:
> Oleg Nesterov <oleg@tv-sign.ru> writes:
> 
>> As Eric pointed out, there is no problem with init starting with sid == pgid
>> == 0, and this was historical linux behavior changed in 2.6.18.
>>
>> Remove kernel_init()->__set_special_pids().
>>
>> This change and the previous change in daemonize() mean that /sbin/init does
>> not need the special "session != 1" hack in sys_setsid() any longer. We can't
>> remove this check yet, we should cleanup copy_process(CLONE_NEWPID) first, so
>> update the comment only.
> 
> I guess that works.  As long as we get there.  We just need one more patch
> in this series to fix the copy_process(CLONE_NEWPID).

I hope this will NOT be the fix that creates the namespace's 
init with the pid == 0 ;)

> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>


  reply	other threads:[~2007-11-27 15:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-27 13:59 [PATCH 4/3] start the global /sbin/init with 0,0 special pids Oleg Nesterov
2007-11-27 15:06 ` Eric W. Biederman
2007-11-27 15:12   ` Pavel Emelyanov [this message]
2007-11-27 15:34     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=474C33DC.7090407@openvz.org \
    --to=xemul@openvz.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.