From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Courtier-Dutton Subject: Re: [PATCH] 1616(M) cardbus improvements Date: Tue, 27 Nov 2007 19:29:31 +0000 Message-ID: <474C701B.4080605@superbug.co.uk> References: <200711160007.00300.c.fertr@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from anchor-post-37.mail.demon.net (anchor-post-37.mail.demon.net [194.217.242.87]) by alsa0.perex.cz (Postfix) with ESMTP id D9C4B244E4 for ; Tue, 27 Nov 2007 20:29:32 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org, Ctirad Fertr List-Id: alsa-devel@alsa-project.org Takashi Iwai wrote: > At Fri, 16 Nov 2007 00:07:00 +0100, > Ctirad Fertr wrote: >> Hello, >> >> this patch improves E-Mu 1616(M) cardbus support. It adds definitions of the >> new Microdock and 1010 cardbus registers (thanks again for descriptions >> James) and improves mixer for this card. Now you can use S/PDIF and ADAT on >> Mirodock and also use headpohone output on host cardbus card as another >> independent output. >> >> Signed-off-by: Ctirad Fertr > > The changes look almost good to me. But, if I understand correctly, > the input source put isn't changed properly for EMU1616. > > The patch below is the revised version with bunch of coding style > fixes (at the next time, try scripts/checkpatch.pl in linux kernel > tree before submission). > Let me know if it works for you. I'll apply to ALSA tree after your > confirmation. > > > Thanks, > > Takashi > Thank you Takashi, I have not had time to look at this patch.