All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH]: tools: fix fw_printenv tool to compile again
Date: Tue, 27 Nov 2007 15:56:18 -0500	[thread overview]
Message-ID: <474C8472.4080706@ge.com> (raw)
In-Reply-To: <87sl2rfmxy.fsf@denx.de>

Markus Klotzb?cher wrote:
> Hi Ben,
> 
> Ben Warren <bwarren@qstreams.com> writes:
> 
>> Markus Klotzb?cher wrote:
>>> How about the following:
>>>
>>> This patch updates the fw_printenv/fw_setenv userspace tool to include
>>> the correct MTD header in order to compile against current kernel
>>> headers. Backward compatibility is preserved by introducing an option
>>> MTD_VERSION which can be set to "old" for compilation using the old MTD
>>> headers. Along with this a number of warnings are fixed.
>>>
>> Sounds good to me.  It'd be cooler if make could detect the
>> presence/absence of <linux/mtd-user.h>, but I'm not enough of a build
>> system whiz to know how to do that.
> 
> I'm afraid nor am I. Suggestions welcome.

I'm not sure it is a reasonable suggestion, but something like...

ifeq ($(strip $(wildcard /usr/include/mtd/mtd-user.h)),)
	MTD_VERSION=old
else
	MTD_VERSION=new
endif

This is using a hardcoded path for <linux/mtd-user.h> (odd, my system 
has it in a different place than Markus referenced - probably my 
ignorance or configuration).  This may be acceptable, or there may be a 
better way to do this.  (Use VPATH?  Things get complicated doing that.)

[snip]

> Viele Gr??e / Best regards
> 
> Markus Klotzb?cher

Best regards,
gvb

  parent reply	other threads:[~2007-11-27 20:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-26 16:46 [U-Boot-Users] [PATCH]: tools: fix fw_printenv tool to compile again Markus Klotzbücher
2007-11-26 17:04 ` Ben Warren
2007-11-26 22:19 ` Wolfgang Denk
2007-11-27  9:23   ` Markus Klotzbücher
2007-11-27 15:34     ` Ben Warren
2007-11-27 20:33       ` Markus Klotzbücher
2007-11-27 20:46         ` Ben Warren
2007-11-27 20:56         ` Jerry Van Baren [this message]
2007-11-27 22:12           ` Wolfgang Denk
2007-11-27 22:06       ` Wolfgang Denk
2007-11-27 22:30         ` Ben Warren
2008-01-09  7:51     ` Wolfgang Denk
2008-01-09 15:19       ` Markus Klotzbücher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=474C8472.4080706@ge.com \
    --to=gerald.vanbaren@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.