From: Johannes Sixt <j.sixt@viscovery.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Wincent Colaiuta <win@wincent.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, tsuna@lrde.epita.fr, mcostalba@gmail.com
Subject: Re: [PATCH] Replace misleading message during interactive rebasing
Date: Wed, 28 Nov 2007 13:53:59 +0100 [thread overview]
Message-ID: <474D64E7.9060603@viscovery.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0711281237250.27959@racer.site>
Johannes Schindelin schrieb:
> You could still provide the "me" and unique_abbrev parameters, so that the
> first %s in _GIT_CHERRY_PICK_HELP would be replaced by the operation, and
> the second by the sha1. Hmm?
Gaah! First rule to safe programming: Don't use user input as format
strings. getenv(_GIT_CHERRY_PICK_HELP) *is* user input. In this case, the
caller knows exactly what the put into the help string, so it should do so.
-- Hannes
prev parent reply other threads:[~2007-11-28 12:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 21:18 [PATCH] Replace misleading message during interactive rebasing Wincent Colaiuta
2007-11-27 8:31 ` Johannes Sixt
2007-11-27 8:49 ` Wincent Colaiuta
2007-11-27 9:46 ` Jeff King
2007-11-27 9:49 ` Jakub Narebski
2007-11-27 9:52 ` Jeff King
2007-11-27 10:15 ` Jeff King
2007-11-28 4:37 ` Junio C Hamano
2007-11-28 8:26 ` Wincent Colaiuta
2007-11-28 12:41 ` Johannes Schindelin
2007-11-28 12:53 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474D64E7.9060603@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mcostalba@gmail.com \
--cc=tsuna@lrde.epita.fr \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.