From: Randy Dunlap <randy.dunlap@oracle.com>
To: Wagner Ferenc <wferi@niif.hu>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] Remove trailing NULs from network bonding sysfs interface.
Date: Wed, 28 Nov 2007 07:38:43 -0800 [thread overview]
Message-ID: <474D8B83.9050609@oracle.com> (raw)
In-Reply-To: <87bq9ekb8m.fsf@szonett.ki.iif.hu>
Wagner Ferenc wrote:
> Randy Dunlap <randy.dunlap@oracle.com> writes:
>
>> On Wed, 28 Nov 2007 01:49:54 +0100 =?utf-8?q?Ferenc_W=C3=A1gner?= wrote:
>>
>> Patches 1 & 3 use
>>
>> if (res) statement;
>>
>> but the preferred form is
>>
>> if (res)
>> statement;
>>
>> Even if this style was already used in the source file, it should
>> be cleaned up.
>
> No principal problem. So that I learn something useful: how should I
> go about this? I created the patches with git-format-patch, and they
> depend on each other, so I'd rather not git-reset, if possible...
>
> Can I just create a follow-up patch which fixes this stylistic issue?
That's OK with me. I can't say how it might be done with git.
Thanks,
--
~Randy
next prev parent reply other threads:[~2007-11-28 15:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 0:52 [PATCH 2/3] net/bonding: Return nothing for not applicable values =?utf-8?q?Ferenc_W=C3=A1gner?=
2007-11-28 0:49 ` [PATCH 1/3] Remove trailing NULs from network bonding sysfs interface =?utf-8?q?Ferenc_W=C3=A1gner?=
2007-11-28 3:49 ` Randy Dunlap
2007-11-28 8:47 ` Wagner Ferenc
2007-11-28 15:38 ` Randy Dunlap [this message]
2007-11-29 0:16 ` [PATCH 4/3] net/bonding: Adhere to coding style: break line after the if condition =?utf-8?q?Ferenc_W=C3=A1gner?=
2007-11-29 1:01 ` Randy Dunlap
2007-11-29 1:13 ` [PATCH 2/3] net/bonding: Return nothing for not applicable values Jay Vosburgh
2007-12-02 12:42 ` [PATCH 1/5] Remove trailing NULs from network bonding sysfs interface Wagner Ferenc
2007-12-02 13:09 ` [PATCH 2/5] net/bonding: Return nothing for not applicable values Wagner Ferenc
2007-12-02 13:09 ` [PATCH 3/5] net/bonding: Purely cosmetic: rename a local variable Wagner Ferenc
2007-12-02 13:10 ` [PATCH 4/5] net/bonding: Adhere to coding style: break line after the if condition Wagner Ferenc
2007-12-02 13:11 ` [PATCH 5/5] net/bonding: Allow setting and querying xmit policy regardless of mode Wagner Ferenc
2007-12-02 13:11 ` Wagner Ferenc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474D8B83.9050609@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wferi@niif.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.