All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Massimo Di Nitto <fabbione@ubuntu.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] Fix qdiskd device scanning logic
Date: Wed, 28 Nov 2007 22:07:21 +0100	[thread overview]
Message-ID: <474DD889.6030801@ubuntu.com> (raw)


Hi Lon,

the original idea of scanning /dev was not too bad but after porting it to
ocfs2-tools and brainstorming again with the guys, we found a few things that
could be done better.

Let's change a direct scan of /dev into:

- scan /sys/block first for well.. block devices.
- sysfs exports enough info for us to filter out removable devices
  like cdroms that we don't care to even check and to gather
  maj/min of each device.
- scan /dev only to match maj/min and gather the device name.
- never dig or attempt to check hidden files.

Please review or apply.

Joel: once applied on top, this is basically the same code that would land
in ocfs2-tools.

Thanks
Fabio

-- 
I'm going to make him an offer he can't refuse.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_proc_part_scan.diff
Type: application/pgp-encrypted
Size: 5980 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20071128/a166c95f/attachment.pgp>

             reply	other threads:[~2007-11-28 21:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-28 21:07 Fabio Massimo Di Nitto [this message]
2007-11-28 22:11 ` [Cluster-devel] Re: [PATCH] Fix qdiskd device scanning logic Joel Becker
2007-11-29  5:08   ` Fabio Massimo Di Nitto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=474DD889.6030801@ubuntu.com \
    --to=fabbione@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.