From: Geoff Levand <geoffrey.levand@am.sony.com>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Linux/PPC Development <linuxppc-dev@ozlabs.org>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [patch 1/7] ps3: Make bus_id and dev_id u64
Date: Wed, 28 Nov 2007 14:16:47 -0800 [thread overview]
Message-ID: <474DE8CF.80305@am.sony.com> (raw)
In-Reply-To: <20071128143438.096659000@pademelon.sonytel.be>
Geert Uytterhoeven wrote:
> ps3: Make bus_id and dev_id u64.
>
> These IDs are 64-bit in the repository, and the special storage notification
> device has a device ID of ULONG_MAX.
>
> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
> ---
> arch/powerpc/platforms/ps3/device-init.c | 4 ++--
> arch/powerpc/platforms/ps3/mm.c | 8 ++++----
> arch/powerpc/platforms/ps3/platform.h | 12 ++++++------
> arch/powerpc/platforms/ps3/repository.c | 21 ++++++++-------------
> arch/powerpc/platforms/ps3/system-bus.c | 14 +++++++-------
> drivers/net/ps3_gelic_net.c | 4 ++--
> include/asm-powerpc/ps3.h | 4 ++--
> 7 files changed, 31 insertions(+), 36 deletions(-)
>
Acked-by: Geoff Levand <geoffrey.levand@am.sony.com>
I saw where 0 passed as a pointer was changed to NULL in your
patch [7] ps3: denoise arch/powerpc/platforms/ps3/repository.c,
so this looks good.
-Geoff
next prev parent reply other threads:[~2007-11-28 22:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 14:31 [patch 0/7] PS3 notification device patches for 2.6.25 Geert Uytterhoeven
2007-11-28 14:31 ` [patch 1/7] ps3: Make bus_id and dev_id u64 Geert Uytterhoeven
2007-11-28 14:31 ` Geert Uytterhoeven
2007-11-28 22:16 ` Geoff Levand [this message]
2007-11-28 14:31 ` [patch 2/7] ps3: Add ps3_repository_find_device_by_id() Geert Uytterhoeven
2007-11-28 14:31 ` Geert Uytterhoeven
2007-11-28 22:18 ` Geoff Levand
2007-11-28 14:31 ` [patch 3/7] ps3: Use the HVs storage device notification mechanism properly Geert Uytterhoeven
2007-11-28 14:31 ` Geert Uytterhoeven
2007-11-28 22:25 ` Geoff Levand
2007-12-20 16:56 ` [patch/rfc " Geert Uytterhoeven
2007-11-28 14:31 ` [patch 4/7] ps3: Add repository polling loop to work around hypervisor bug Geert Uytterhoeven
2007-11-28 14:31 ` Geert Uytterhoeven
2007-11-28 22:28 ` Geoff Levand
2007-11-28 14:31 ` [patch 5/7] ps3: Kill unused ps3_repository_bump_device() Geert Uytterhoeven
2007-11-28 14:31 ` Geert Uytterhoeven
2007-11-28 22:46 ` Geoff Levand
2007-11-28 14:31 ` [patch 6/7] ps3: Refactor ps3_repository_find_device() Geert Uytterhoeven
2007-11-28 14:31 ` Geert Uytterhoeven
2007-11-28 22:48 ` Geoff Levand
2007-11-28 14:31 ` [patch 7/7] ps3: denoise arch/powerpc/platforms/ps3/repository.c Geert Uytterhoeven
2007-11-28 14:31 ` Geert Uytterhoeven
2007-11-28 22:49 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474DE8CF.80305@am.sony.com \
--to=geoffrey.levand@am.sony.com \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.