From: Mark Lord <lkml@rtr.ca>
To: Linux Kernel <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@suse.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] base/class.c: prevent ooops due to insert/remove race
Date: Wed, 28 Nov 2007 23:00:36 -0500 [thread overview]
Message-ID: <474E3964.7040200@rtr.ca> (raw)
While doing insert/remove (quickly) tests on USB, I managed to trigger
an Oops on 2.6.23.1 on the call to strlen() in make_class_name().
This patch prevents this oops.
There is still the larger problem of the overall race
that caused this in the first place, but much of the rest
of the code in class.c appears to also do NULL checks to
avoid Oops'ing, so this continues the tradition.
Signed-off-by: Mark Lord <mlord@pobox.com>
---
Patch applies to both 2.6.24 and 2.6.23.
--- old/drivers/base/class.c 2007-11-28 22:54:59.000000000 -0500
+++ linux/drivers/base/class.c 2007-11-28 22:54:48.000000000 -0500
@@ -354,6 +354,8 @@
char *class_name;
int size;
+ if (!name)
+ return NULL;
size = strlen(name) + strlen(kobject_name(kobj)) + 2;
class_name = kmalloc(size, GFP_KERNEL);
next reply other threads:[~2007-11-29 4:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 4:00 Mark Lord [this message]
2007-11-29 4:33 ` [PATCH] base/class.c: prevent ooops due to insert/remove race Greg KH
2007-11-29 15:41 ` Mark Lord
2007-11-29 16:27 ` Greg KH
2007-11-29 17:45 ` Mark Lord
2007-11-29 17:48 ` Mark Lord
2007-11-29 17:50 ` Mark Lord
2007-11-29 18:09 ` [PATCH] base/class.c: prevent ooops due to insert/remove race (v3) Mark Lord
2007-11-29 18:12 ` Mark Lord
2007-11-29 19:20 ` [linux-usb-devel] " Alan Stern
2007-11-29 20:01 ` Mark Lord
2007-11-29 20:12 ` Greg KH
[not found] ` <474F1DB3.4030900@rtr.ca>
2007-11-29 20:25 ` Mark Lord
2007-11-29 20:32 ` Greg KH
2007-11-29 20:46 ` Mark Lord
2007-11-29 21:17 ` Greg KH
2007-11-29 22:07 ` Alan Stern
2007-11-29 22:11 ` Greg KH
2007-11-29 22:28 ` Mark Lord
2007-11-29 22:43 ` Alan Stern
2007-11-29 23:09 ` Linus Torvalds
2007-11-30 2:58 ` Alan Stern
2007-11-29 20:13 ` Alan Stern
2007-11-29 20:17 ` Mark Lord
2007-11-29 20:20 ` Mark Lord
2007-11-29 21:59 ` Alan Stern
2007-11-29 15:59 ` [PATCH] base/class.c: prevent ooops due to insert/remove race (v2) Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474E3964.7040200@rtr.ca \
--to=lkml@rtr.ca \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.