All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 14/15] ide: remove 'command_type' field from ide_task_t
Date: Thu, 29 Nov 2007 19:47:58 +0300	[thread overview]
Message-ID: <474EED3E.4030404@ru.mvista.com> (raw)
In-Reply-To: <200710310055.17380.bzolnier@gmail.com>

Bartlomiej Zolnierkiewicz wrote:

> * Add 'data_buf' and 'nsect' variables in ide_taskfile_ioctl()
>   to cache data buffer pointer and number of sectors to transfer
>   (this allows us to have only one ide_diag_taskfile() call).

> * Add IDE_TFLAG_WRITE taskfile flag and use it to check whether
>   the REQ_RW request flag should be set.

> * Move ->command_type handling from ide_diag_taskfile() to
>   ide_taskfile_ioctl() and use ->req_cmd instead of ->command_type.

> * Add 'nsect' parameter to ide_raw_taskfile().

> * Merge ide_diag_taskfile() into ide_raw_taskfile().

> * Initialize ->data_phase explicitly in idedisk_prepare_flush(),
>   ide_start_power_step() and ide_disk_special().

> * Remove no longer needed 'command_type' field from ide_task_t.

> * Add #ifndef/#endif __KERNEL__ to <linux/hdreg.h> around no
>   longer used by kernel IDE_DRIVE_TASK_* and TASKFILE_* defines.

> There should be no functionality changes caused by this patch.

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

MBR, Sergei

      reply	other threads:[~2007-11-29 16:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-30 23:55 [PATCH 14/15] ide: remove 'command_type' field from ide_task_t Bartlomiej Zolnierkiewicz
2007-11-29 16:47 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=474EED3E.4030404@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.