From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 6/9] ide: remove 'handler' field from ide_task_t
Date: Thu, 29 Nov 2007 20:37:39 +0300 [thread overview]
Message-ID: <474EF8E3.5030605@ru.mvista.com> (raw)
In-Reply-To: <200711030400.11562.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
>>* Add IDE_TFLAG_CUSTOM_HANDLER taskfile flag and use it for internal requests
>> which require custom handlers. Check the flag in do_rw_taskfile() and set
>> handler accordingly.
>>* Cleanup ide_init_{specify,restore,setmult}_cmd() and rename it to
>> ide_tf_set_{specify,restore,setmult}_cmd().
>>* Make {set_geometry,recal,set_multmode}_intr() static.
>>* Remove no longer needed 'handler' field from ide_task_t.
>>There should be no functionality changes caused by this patch.
> except that it doesn't work 8) working version below
> [PATCH] ide: remove 'handler' field from ide_task_t (take 2)
> * Add IDE_TFLAG_CUSTOM_HANDLER taskfile flag and use it for internal requests
> which require custom handlers. Check the flag in do_rw_taskfile() and set
> handler accordingly.
> * Cleanup ide_init_{specify,restore,setmult}_cmd() and rename it to
> ide_tf_set_{specify,restore,setmult}_cmd().
> * Make {set_geometry,recal,set_multmode}_intr() static.
> * Remove no longer needed 'handler' field from ide_task_t.
> v2:
> * 'handler' in do_rw_taskfile() must be set to NULL initially.
> There should be no functionality changes caused by this patch.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
prev parent reply other threads:[~2007-11-29 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 22:05 [PATCH 6/9] ide: remove 'handler' field from ide_task_t Bartlomiej Zolnierkiewicz
2007-11-03 3:00 ` Bartlomiej Zolnierkiewicz
2007-11-29 17:37 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474EF8E3.5030605@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.