From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Chuck Ebbert <cebbert@redhat.com>,
Roland McGrath <roland@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task
Date: Thu, 29 Nov 2007 10:16:22 -0800 [thread overview]
Message-ID: <474F01F6.2030509@zytor.com> (raw)
In-Reply-To: <alpine.LFD.0.9999.0711290958110.8458@woody.linux-foundation.org>
Linus Torvalds wrote:
>
> But this one is correct:
>
>>> case offsetof(struct user32, regs.gs):
>>> *val = child->thread.gsindex;
>>> + if (child == current)
>>> + asm("movl %%gs,%0" : "=r" (*val));
>> Won't this return the kernel's GS instead of the user's?
>
> No, %gs is untouched by the kernel, so it contains user space version, and
> getting the value directly from %gs looks correct.
>
Brief summary/reminder:
The kernel uses %fs in 32-bit mode and %gs in 64-bit mode.
User space TLS uses %gs in 32-bit mode and %fs in 64-bit mode.
The 64-bit kernel has to use %gs in order for SWAPGS to be available to
it (by which time the 32-bit ABI was already fixed.) It is advantageous
for user space to use the register the kernel typically won't, in order
to speed up system call entry/exit.
-hpa
next prev parent reply other threads:[~2007-11-29 18:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 0:38 [PATCH x86/mm 1/6] x86-64 ia32 ptrace pt_regs cleanup Roland McGrath
2007-11-29 0:40 ` [PATCH x86/mm 2/6] x86-64 ptrace whitespace Roland McGrath
2007-11-29 0:40 ` [PATCH x86/mm 3/6] x86-32 " Roland McGrath
2007-11-29 0:41 ` [PATCH x86/mm 4/6] x86-64 ptrace get/putreg current task Roland McGrath
2007-11-29 17:39 ` Christoph Hellwig
2007-11-29 0:42 ` [PATCH x86/mm 5/6] x86-32 " Roland McGrath
2007-11-29 0:42 ` [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 " Roland McGrath
2007-11-29 17:34 ` Chuck Ebbert
2007-11-29 18:09 ` Linus Torvalds
2007-11-29 18:16 ` H. Peter Anvin [this message]
2007-11-29 18:31 ` Linus Torvalds
2007-11-29 18:45 ` H. Peter Anvin
2007-11-29 19:08 ` Linus Torvalds
2007-11-29 19:16 ` H. Peter Anvin
2007-11-29 19:27 ` Andi Kleen
2007-11-29 19:44 ` Ingo Molnar
2007-11-29 20:01 ` H. Peter Anvin
2007-12-01 23:44 ` Jeremy Fitzhardinge
2007-11-29 19:49 ` Linus Torvalds
2007-11-29 20:11 ` Andi Kleen
2007-11-29 20:23 ` Linus Torvalds
2007-11-29 18:17 ` Chuck Ebbert
2007-11-29 18:23 ` H. Peter Anvin
2007-11-29 22:25 ` Roland McGrath
2007-11-29 22:34 ` Linus Torvalds
2007-11-29 22:21 ` Roland McGrath
2007-11-29 23:00 ` Chuck Ebbert
2007-11-29 10:39 ` [PATCH x86/mm 1/6] x86-64 ia32 ptrace pt_regs cleanup Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474F01F6.2030509@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=cebbert@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.