All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] libsensors: No longer depend on libsysfs
Date: Thu, 29 Nov 2007 18:16:39 +0000	[thread overview]
Message-ID: <474F0207.9020905@hhs.nl> (raw)
In-Reply-To: <20071129120153.26879145@hyperion.delvare>

Jean Delvare wrote:
> Hi all,
> 
> Here is a proposed patch to make libsensors no longer depend on
> libsysfs. Instead, it accesses sysfs directly, using 3 embedded helper
> functions. My motivations for doing this are:
> * As far as I know, libsysfs is no longer maintained.
> * libsysfs does much more than we need. For example, when asking for a
>   device attribute list, libsysfs will read the contents and permissions
>   of all attributes. Not only does this waste CPU cycles per se, but in
>   the case of hwmon driver it also triggers register reads, which can be
>   slow for SMBus chips.
> * libsysfs enforces the difference between devices and class devices,
>   while future changes will be easier if we can handle both types alike.
> 

Good work!

I'm afraid I don't have the time to review this atm though, any other takers?

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2007-11-29 18:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29 11:01 [lm-sensors] [PATCH] libsensors: No longer depend on libsysfs Jean Delvare
2007-11-29 18:16 ` Hans de Goede [this message]
2007-11-29 18:52 ` Jean Delvare
2007-12-02 19:39 ` Hans de Goede
2007-12-02 20:42 ` Jean Delvare
2007-12-10 13:30 ` Jean Delvare
2007-12-16 18:59 ` Mark M. Hoffman
2007-12-16 19:25 ` Jean Delvare
2007-12-16 19:41 ` Mark M. Hoffman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=474F0207.9020905@hhs.nl \
    --to=j.w.r.degoede@hhs.nl \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.