From: Mark Lord <lkml@rtr.ca>
To: kristen.c.accardi@intel.com
Cc: jeff@garzik.org, akpm@linux-foundation.org,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] ata: ahci: Enclosure Management via LED
Date: Thu, 29 Nov 2007 15:04:17 -0500 [thread overview]
Message-ID: <474F1B41.5040302@rtr.ca> (raw)
In-Reply-To: <20071129112220.55310ff5@appleyard>
Kristen Carlson Accardi wrote:
> On Thu, 29 Nov 2007 13:16:07 -0500
> Mark Lord <lkml@rtr.ca> wrote:
>
>> Kristen wrote:
>> ...
>>> + * XXX will need Port Multiplier support
>> What's that all about ?
>>
>
> I didn't have any hardware that had LED support as well as Port
> Multiplier, so I didn't implement port multiplier support for this. I
> wasn't sure if it was better to just do it anyway, or leave it for when
> we actually have hardware that needs it.
..
Good. So please replace the "XXX" comment with the better
explanation given in your posting above. That'll make future
maintenance a lot less guessy.
Cheers
next prev parent reply other threads:[~2007-11-29 20:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 17:48 [patch] ata: ahci: Enclosure Management via LED Kristen Carlson Accardi
2007-11-29 18:16 ` Mark Lord
2007-11-29 19:22 ` Kristen Carlson Accardi
2007-11-29 20:04 ` Mark Lord [this message]
2007-11-29 18:43 ` Kristen Carlson Accardi
2007-12-05 11:13 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2007-11-29 20:19 Kristen Carlson Accardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474F1B41.5040302@rtr.ca \
--to=lkml@rtr.ca \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=kristen.c.accardi@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.