All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bryan O'Sullivan" <bos@serpentine.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Question regarding mutex locking
Date: Thu, 29 Nov 2007 17:13:09 -0800	[thread overview]
Message-ID: <474F63A5.2000907@serpentine.com> (raw)
In-Reply-To: <474CF06C.8020208@lwfinger.net>

Larry Finger wrote:
> If a particular routine needs to lock a mutex, but it may be entered with that mutex already locked,
> would the following code be SMP safe?
> 
> hold_lock = mutex_trylock()

The common way to deal with this is first to restructure your function 
into two.  One always acquires the lock, and the other (often written 
with a "__" prefix) never acquires it.  The never-acquire code does the 
actual work, and the always-acquire function calls it.

You then refactor the callers so that you don't have any code paths on 
which you can't predict whether or not the lock will be held.

	<b

  parent reply	other threads:[~2007-11-30  1:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-28  4:37 Question regarding mutex locking Larry Finger
2007-11-28  8:10 ` Matthias Kaehlcke
2007-11-28 14:46   ` Larry Finger
2007-11-28 15:00     ` Matthias Kaehlcke
2007-11-28 15:22 ` Andreas Schwab
2007-11-28 15:41   ` Larry Finger
2007-11-28 22:45     ` Jarek Poplawski
2007-11-28 22:56       ` Jarek Poplawski
2007-11-28 23:07         ` Jarek Poplawski
2007-11-28 23:33       ` Stephen Hemminger
2007-11-29  6:40         ` Jarek Poplawski
2007-11-30  1:13 ` Bryan O'Sullivan [this message]
     [not found] <fa.C9TdvYAhY8SablNc39IpD8WDnNM@ifi.uio.no>
2007-11-28  4:53 ` Robert Hancock
2007-11-28  5:19   ` Larry Finger
2007-11-29  2:34     ` David Schwartz
2007-11-29  7:56       ` Jarek Poplawski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=474F63A5.2000907@serpentine.com \
    --to=bos@serpentine.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.