From: Pavel Emelyanov <xemul@openvz.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devel@openvz.org
Subject: [PATCH 6/7][MQUEUE] Move sysctl management code under ifdef CONFIG_SYSCTL
Date: Fri, 30 Nov 2007 16:16:29 +0300 [thread overview]
Message-ID: <47500D2D.3050000@openvz.org> (raw)
In-Reply-To: <475008F5.3000506@openvz.org>
This includes the tables, the mq_sysctl_table ctl header
and calls to register/unregister.
Just like with the quota patch, I hope this is OK to
keep the ifdefs inside the __init function, rather
than making handlers and stubs outside it.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
diff --git a/ipc/mqueue.c b/ipc/mqueue.c
index 7d1b8aa..9ff4abf 100644
--- a/ipc/mqueue.c
+++ b/ipc/mqueue.c
@@ -94,8 +94,6 @@ static unsigned int queues_max = DFLT_QUEUESMAX;
static unsigned int msg_max = DFLT_MSGMAX;
static unsigned int msgsize_max = DFLT_MSGSIZEMAX;
-static struct ctl_table_header * mq_sysctl_table;
-
static inline struct mqueue_inode_info *MQUEUE_I(struct inode *inode)
{
return container_of(inode, struct mqueue_inode_info, vfs_inode);
@@ -1201,6 +1199,7 @@ static int msg_max_limit_max = HARD_MSGMAX;
static int msg_maxsize_limit_min = DFLT_MSGSIZEMAX;
static int msg_maxsize_limit_max = INT_MAX;
+#ifdef CONFIG_SYSCTL
static ctl_table mq_sysctls[] = {
{
.procname = "queues_max",
@@ -1249,6 +1248,9 @@ static ctl_table mq_sysctl_root[] = {
{ .ctl_name = 0 }
};
+static struct ctl_table_header *mq_sysctl_table;
+#endif
+
static int __init init_mqueue_fs(void)
{
int error;
@@ -1258,10 +1260,10 @@ static int __init init_mqueue_fs(void)
SLAB_HWCACHE_ALIGN, init_once);
if (mqueue_inode_cachep == NULL)
return -ENOMEM;
-
+#ifdef CONFIG_SYSCTL
/* ignore failues - they are not fatal */
mq_sysctl_table = register_sysctl_table(mq_sysctl_root);
-
+#endif
error = register_filesystem(&mqueue_fs_type);
if (error)
goto out_sysctl;
@@ -1280,8 +1282,10 @@ static int __init init_mqueue_fs(void)
out_filesystem:
unregister_filesystem(&mqueue_fs_type);
out_sysctl:
+#ifdef CONFIG_SYSCTL
if (mq_sysctl_table)
unregister_sysctl_table(mq_sysctl_table);
+#endif
kmem_cache_destroy(mqueue_inode_cachep);
return error;
}
--
1.5.3.4
next prev parent reply other threads:[~2007-11-30 13:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 12:58 [PATCH 0/7] Start using sysctl paths in the core kernel code Pavel Emelyanov
2007-11-30 13:02 ` [PATCH 1/7][QUOTA] Move sysctl management code under ifdef CONFIG_SYSCTL Pavel Emelyanov
2007-12-03 21:38 ` Andrew Morton
2007-12-03 23:32 ` Eric W. Biederman
2007-12-04 8:58 ` Pavel Emelyanov
2007-12-04 9:23 ` Andrew Morton
2007-12-04 9:31 ` Pavel Emelyanov
2007-12-04 9:45 ` Andrew Morton
2007-12-04 11:40 ` Eric W. Biederman
2007-12-04 11:48 ` Andrew Morton
2007-12-04 11:58 ` Pavel Emelyanov
2007-12-04 12:48 ` Eric W. Biederman
2007-11-30 13:04 ` [PATCH 2/7][QUOTA] Use sysctl paths to register tables Pavel Emelyanov
2007-11-30 13:09 ` [PATCH 3/7][SYSVIPC] Use the ctl " Pavel Emelyanov
2007-11-30 13:11 ` [PATCH 4/7][SCHED] " Pavel Emelyanov
2007-11-30 13:13 ` [PATCH 5/7][UTS] " Pavel Emelyanov
2007-11-30 13:16 ` Pavel Emelyanov [this message]
2007-11-30 13:18 ` [PATCH 7/7][MQUEUE] " Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47500D2D.3050000@openvz.org \
--to=xemul@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=devel@openvz.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.