From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: [PATCH] 2.6.24: restore missing sysfs max_cstate attr Date: Fri, 30 Nov 2007 14:06:19 -0500 Message-ID: <47505F2B.2090109@rtr.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rtr.ca ([76.10.145.34]:4082 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756062AbXK3TGV (ORCPT ); Fri, 30 Nov 2007 14:06:21 -0500 Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Linux Kernel , Linux Kernel , len.brown@intel.com, Andrew Morton Len, is there any good reason why max_cstate was made invisible in 2.6.24, breaking my userspace scripts that access it? Here's a patch to fix the regression from 2.6.23: Restore visibility of /sys/module/processor/parameters/max_cstate for compatibility with kernels prior to 2.6.24. I have scripts here that rely upon it. Signed-off-by: Mark Lord --- Patch is against 2.6.24-rc3-git5. --- linux/drivers/acpi/processor_idle.c.orig 2007-11-30 13:35:20.000000000 -0500 +++ linux/drivers/acpi/processor_idle.c 2007-11-30 13:35:31.000000000 -0500 @@ -76,7 +76,7 @@ #define PM_TIMER_TICKS_TO_US(p) (((p) * 1000)/(PM_TIMER_FREQUENCY/1000)) static unsigned int max_cstate __read_mostly = ACPI_PROCESSOR_MAX_POWER; -module_param(max_cstate, uint, 0000); +module_param(max_cstate, uint, 0644); static unsigned int nocst __read_mostly; module_param(nocst, uint, 0000);