All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Emelyanov <xemul@openvz.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Netdev List <netdev@vger.kernel.org>, devel@openvz.org
Subject: Re: [PATCH net-2.6.25 2/3][IPV4] Unify and cleanup calls to devinet_sysctl_register
Date: Sat, 01 Dec 2007 16:25:21 +0300	[thread overview]
Message-ID: <475160C1.9050808@openvz.org> (raw)
In-Reply-To: <20071201132000.GG15910@gondor.apana.org.au>

Herbert Xu wrote:
> On Fri, Nov 30, 2007 at 09:26:58PM +0300, Pavel Emelyanov wrote:
>> Besides, the inet_device is passed to this function, but
>> it is not needed there at all - just the device name and
>> ifindex are required.
> 
> But it is called devinet_* so an in_dev kind of makes sense :)
> 
>>  #ifdef CONFIG_SYSCTL
>> -	devinet_sysctl_register(in_dev, &in_dev->cnf);
>> +	devinet_sysctl_register(dev, &in_dev->cnf);
> 
> How about just giving it in_dev instead?

Hmm... Makes sense. Should I recreate the while set or
just make the incremental one?

> Thanks,

Thanks,
Pavel

  reply	other threads:[~2007-12-01 13:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-30 18:26 [PATCH net-2.6.25 2/3][IPV4] Unify and cleanup calls to devinet_sysctl_register Pavel Emelyanov
2007-12-01 13:20 ` Herbert Xu
2007-12-01 13:25   ` Pavel Emelyanov [this message]
2007-12-01 13:28     ` Herbert Xu
2007-12-01 13:38       ` [PATCH net-2.6.25 (resend) " Pavel Emelyanov
2007-12-01 13:39       ` [PATCH net-2.6.25 (resend) 3/3][IPV4] Use ctl paths to register devinet sysctls Pavel Emelyanov
2007-12-01 13:57         ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=475160C1.9050808@openvz.org \
    --to=xemul@openvz.org \
    --cc=devel@openvz.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.