All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: netdev@vger.kernel.org, linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH] SGISEEQ: use cached memory access to make driver work on IP28
Date: Sat, 01 Dec 2007 16:57:11 -0500	[thread overview]
Message-ID: <4751D8B7.1060508@pobox.com> (raw)
In-Reply-To: <20071126223934.84BE7C2B26@solo.franken.de>

Thomas Bogendoerfer wrote:
> Following patch is clearly 2.6.25 material and is needed to get SGI IP28
> machines supported.
> 
> Thomas.
> 
> SGI IP28 machines would need special treatment (enable adding addtional
> wait states) when accessing memory uncached. To avoid this pain I changed
> the driver to use only cached access to memory.
> 
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>

applied.  As I have noted to you previously, /please/ put extraneous 
comments /after/ a "---" separator, so that they are not copied by 
git-am (Linus's email patch import tool) into the permanent kernel 
changelog.

The above should look like:

<snip>
SGI IP28 machines would need special treatment (enable adding addtional 
wait states) when accessing memory uncached. To avoid this pain I 
changed the driver to use only cached access to memory.

Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
Following patch is clearly 2.6.25 material and is needed to get SGI IP28 
machines supported.

Thomas.

  drivers/net/sgiseeq.c |  239 
++++++++++++++++++++++++++++++++++---------------
  1 files changed, 166 insertions(+), 73 deletions(-)
</snip>


See Documentation/SubmittingPatches for more details, in particular "14) 
The canonical patch format" or http://linux.yyz.us/patch-format.html

	Jeff

      parent reply	other threads:[~2007-12-01 21:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-24 12:29 [PATCH] SGISEEQ: use cached memory access to make driver work on IP28 Thomas Bogendoerfer
2007-11-27 16:32 ` Ralf Baechle
2007-12-01 21:57 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4751D8B7.1060508@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=linux-mips@linux-mips.org \
    --cc=netdev@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.