From: Jarek Poplawski <jarkao2@o2.pl>
To: Laszlo Attila Toth <panther@balabit.hu>
Cc: David Miller <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org
Subject: Re: [PATCHv7 iproute2 2/2] Interface group as new ip link option
Date: Sat, 01 Dec 2007 23:10:50 +0100 [thread overview]
Message-ID: <4751DBEA.3050705@o2.pl> (raw)
In-Reply-To: <11963527101117-git-send-email-panther@balabit.hu>
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM:
> Interfaces can be grouped and each group has an unique positive integer ID.
> It can be set via ip link. Symbolic names can be specified in
> /etc/iproute2/rt_ifgroup. Any value of unsigned int32 is valid.
...
> diff --git a/lib/rt_names.c b/lib/rt_names.c
> index 8d019a0..ec6638c 100644
> --- a/lib/rt_names.c
> +++ b/lib/rt_names.c
> @@ -439,10 +439,72 @@ int rtnl_dsfield_a2n(__u32 *id, char *arg)
> }
> }
>
> - res = strtoul(arg, &end, 16);
> + res = strtoul(arg, &end, 0);
Won't this break any scripts?
Jarek P.
next prev parent reply other threads:[~2007-12-01 22:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 16:11 [PATCHv7 0/5 + 3] Interface group patches Laszlo Attila Toth
2007-11-29 16:11 ` Laszlo Attila Toth
2007-11-29 16:25 ` Patrick McHardy
2007-11-29 16:39 ` Laszlo Attila Toth
2007-11-29 16:11 ` [PATCHv7 1/5] Remove unnecessary locks from rtnetlink (in do_setlink) Laszlo Attila Toth
2007-11-30 22:13 ` Jarek Poplawski
2007-12-03 11:59 ` Laszlo Attila Toth
2007-12-18 12:29 ` [PATCHv7 1/5][RESEND] Remove unnecessary locks from rtnetlink Laszlo Attila Toth
2007-11-29 16:11 ` [PATCHv7 2/5] rtnetlink: send a single notification on device state changes Laszlo Attila Toth
2007-11-30 23:24 ` Jarek Poplawski
2007-12-03 11:40 ` Laszlo Attila Toth
2007-12-03 13:37 ` Jarek Poplawski
2007-12-18 12:29 ` [PATCHv7 2/5][RESEND] " Laszlo Attila Toth
2007-11-29 16:11 ` [PATCHv7 3/5] Interface group: core (netlink) part Laszlo Attila Toth
2007-11-29 16:11 ` [PATCHv7 4/5] Ifgroup read/write support in sysfs Laszlo Attila Toth
2007-11-29 16:11 ` [PATCHv7 5/5] Netfilter Interface group match Laszlo Attila Toth
2007-11-29 16:11 ` [PATCHv7 iptables] " Laszlo Attila Toth
2007-12-01 21:19 ` Jarek Poplawski
2007-12-01 21:23 ` Jarek Poplawski
2007-11-29 16:11 ` [PATCHv7 iproute2 1/2] Added IFLA_NET_NS_PID as in kernel v2.6.24-rc1 Laszlo Attila Toth
2007-11-29 16:11 ` [PATCHv7 iproute2 2/2] Interface group as new ip link option Laszlo Attila Toth
2007-12-01 22:10 ` Jarek Poplawski [this message]
2007-12-18 12:29 ` [PATCHv7 iproute2 2/2][RESEND] " Laszlo Attila Toth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4751DBEA.3050705@o2.pl \
--to=jarkao2@o2.pl \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=panther@balabit.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.