All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Mark Lord <liml@rtr.ca>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
	Tejun Heo <htejun@gmail.com>, Alan Cox <alan@redhat.com>,
	Tom Morrison <tmorrison@empirix.com>,
	Hein-Pieter van Braam <hp@syntomax.com>
Subject: Re: [PATCH] sata_mv:  Fix broken Marvell 7042 support.
Date: Sat, 01 Dec 2007 17:45:43 -0500	[thread overview]
Message-ID: <4751E417.7060308@pobox.com> (raw)
In-Reply-To: <4751A2DA.6030403@rtr.ca>

Mark Lord wrote:
> sata_mv:  Fix broken Marvell 7042 support.
> 
> The Marvell 7042 chip is more or less the same as the 6042 internally,
> but sports a PCIe bus.  Despite having identical SATA cores, the 7042
> does differ from its PCI bus counterparts in placment and layout of
> certain bus related registers.
> 
> This patch fixes sata_mv to distinguish between the PCI bus registers
> of earlier chips, and the PCIe bus registers of the 7042.
> 
> Specifically, move the offsets and bit patterns for the
> PCI/PCIe interrupt cause/mask registers into the struct mv_host_priv,
> as these values differ between the 6xxx and 7xxx series chips.
> 
> This fixes the driver to not access reserved PCI addresses,
> and prevents the lockups reported in linux-2.6.24 with 7042 boards.
> 
> Also add a new PCI ID for the Highpoint 2300 7042-based board
> that I'm using for testing this stuff here.
> 
> Tested with Marvell 6081 + 7042 chips, on x86 & x86_64.
> 
> Signed-off-by: Mark Lord <mlord@pobox.com>

applied #upstream-fixes



  parent reply	other threads:[~2007-12-01 22:45 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-01 18:07 [PATCH] sata_mv: Fix broken Marvell 7042 support Mark Lord
2007-12-01 18:16 ` Alan Cox
2007-12-01 22:45 ` Jeff Garzik [this message]
2007-12-03 12:27 ` Morrison, Tom
2007-12-03 14:47   ` hp
2007-12-03 14:56     ` Morrison, Tom
2007-12-03 17:26     ` Mark Lord
2007-12-03 18:14       ` Mark Lord
2007-12-03 18:30         ` Jeff Garzik
2007-12-03 18:32           ` Mark Lord
2007-12-03 18:37             ` Morrison, Tom
2007-12-03 18:40               ` Mark Lord
2007-12-03 18:44                 ` Mark Lord
2007-12-03 18:42                   ` Alan Cox
2007-12-03 19:12                     ` Mark Lord
2007-12-03 20:40                       ` Mark Lord
2007-12-03 23:59                         ` Mark Lord
2007-12-04  0:20                           ` [PATCH] sata_mv: Warn about Highpoint RocketRAID BIOS treatment of "Legacy" drives Mark Lord
2007-12-04 19:09                             ` Jeff Garzik
2007-12-03 18:30         ` [PATCH] sata_mv: Fix broken Marvell 7042 support Mark Lord
2007-12-03 20:11           ` Hein-Pieter van Braam
2007-12-03 20:24             ` Mark Lord
2007-12-03 20:37               ` Hein-Pieter van Braam
2007-12-03 20:54                 ` Mark Lord
2007-12-03 22:28                   ` Hein-Pieter van Braam
2007-12-03 23:37                     ` Mark Lord
2007-12-03 22:48                   ` Hein-Pieter van Braam
2007-12-03 23:10                     ` Alan Cox
2007-12-03 23:33                       ` Mark Lord
2007-12-03 23:34                         ` Alan Cox
2007-12-03 23:47                       ` Mark Lord
2007-12-03 23:47                         ` Alan Cox
2007-12-04  0:01                       ` Hein-Pieter van Braam
2007-12-04  0:07                         ` Mark Lord
2007-12-04  0:17                           ` Hein-Pieter van Braam
2007-12-04  0:23                             ` Mark Lord
2007-12-04  0:35                               ` Hein-Pieter van Braam
2007-12-04  0:36                               ` Mark Lord
2007-12-04 23:56                               ` Hein-Pieter van Braam
2007-12-05 22:45                                 ` Mark Lord
2007-12-05 23:22                                   ` Mark Lord
2007-12-05 23:35                                     ` Mark Lord
2007-12-05 23:55                                       ` Mark Lord
2007-12-06  0:02                                         ` Jeff Garzik
2007-12-06  3:57                                           ` Mark Lord
2007-12-06  4:45                                             ` Jeff Garzik
2007-12-06 22:24                                               ` Mark Lord
2007-12-06  4:03                                           ` Mark Lord
2007-12-06  4:43                                             ` Jeff Garzik
2007-12-06 22:23                                               ` Mark Lord
2007-12-07  2:22                                                 ` Jeff Garzik
2007-12-06 22:32                                           ` Mark Lord
2007-12-04 19:21                             ` Hein-Pieter van Braam
2007-12-04  1:17           ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4751E417.7060308@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=alan@redhat.com \
    --cc=hp@syntomax.com \
    --cc=htejun@gmail.com \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    --cc=tmorrison@empirix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.