All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: mikpe@it.uu.se, linux-ide@vger.kernel.org
Subject: Re: [PATCH RFC] sata_promise: make pdc_atapi_pkt() use values from qc->tf
Date: Sat, 01 Dec 2007 18:23:44 -0500	[thread overview]
Message-ID: <4751ED00.90802@garzik.org> (raw)
In-Reply-To: <20071126113438.GB9232@htj.dyndns.org>

Tejun Heo wrote:
> Make pdc_atapi_pkt() use values from qc->tf instead of creating its
> own.  This is to ease future ATAPI handling changes.
> 
> DONT APPLY YET
> ---
> Mikael, would this work?  Values other than lbam and lbah remain the
> same.  Does sata_promise have strict requirements for lbam and lbah?
> 
> Thanks.
> 
>  drivers/ata/sata_promise.c |   34 +++++++++++++---------------------
>  1 file changed, 13 insertions(+), 21 deletions(-)

what was the outcome of this discussion?

I haven't looked over the Promise datasheet nor checked my brain for 
details, hoping Mikael would do that for me ;-)



  reply	other threads:[~2007-12-01 23:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-26 11:34 [PATCH RFC] sata_promise: make pdc_atapi_pkt() use values from qc->tf Tejun Heo
2007-12-01 23:23 ` Jeff Garzik [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-11-26 12:00 Mikael Pettersson
2007-11-26 12:18 ` Tejun Heo
2007-12-02 17:06 Mikael Pettersson
2007-12-03  4:49 ` Tejun Heo
2007-12-03  8:41 Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4751ED00.90802@garzik.org \
    --to=jeff@garzik.org \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=mikpe@it.uu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.