From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: "Zhang, Xiantao" <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] Eliminate the difference of ioapic andiosapic
Date: Sun, 02 Dec 2007 22:35:22 +0200 [thread overview]
Message-ID: <4753170A.7010905@qumranet.com> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDCA3991B-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Zhang, Xiantao wrote:
> Avi Kivity wrote:
>
>> Zhang, Xiantao wrote:
>>
>>> I didin't create the ioapic.h, since current irq.h has included
>>> most the definitions of ioapic. Maybe we can create it later for
>>> irq.h split. Now, I just put the definition in irq.h for delivery
>>> mode. Since the delivery mode definitions doesn't depend on kernel
>>> header files, so it will avoid possible failures with some special
>>> .configs.
>>>
>>>
>> Patch looks good, but please split into the dest_* -> IOAPIC_* change,
>> and the lapic -> vcpu change, since the combined patch is a little
>> big.
>>
> Done! Attached the patches. :)
>
Applied all; thanks. But please use git-send-email to send patches,
they're easier to review that way.
--
Any sufficiently difficult bug is indistinguishable from a feature.
-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell. From the desktop to the data center, Linux is going
mainstream. Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
prev parent reply other threads:[~2007-12-02 20:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 10:25 [PATCH] Eliminate the difference of ioapic and iosapic Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDCA3951B-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-11-30 7:45 ` Avi Kivity
[not found] ` <474FBFAB.7020407-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-30 8:23 ` [PATCH] Eliminate the difference of ioapic andiosapic Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDCA397B3-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-11-30 8:32 ` Avi Kivity
[not found] ` <474FCA8C.2090809-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-30 10:22 ` Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDCA3981F-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-11-30 11:57 ` Avi Kivity
[not found] ` <474FFA8F.7040403-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-30 11:59 ` Zhang, Xiantao
2007-12-02 12:29 ` Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDCA398ED-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-12-02 12:43 ` Avi Kivity
[not found] ` <4752A859.2040909-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-12-02 14:57 ` Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDCA3991B-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-12-02 20:35 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4753170A.7010905@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.