From: Richard Knutsson <ricknu-0@student.ltu.se>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: v4l-dvb-maintainer@linuxtv.org, mchehab@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [v4l-dvb-maintainer] [PATCH 1/2] ivtv: Some general fixes
Date: Sun, 02 Dec 2007 23:06:48 +0100 [thread overview]
Message-ID: <47532C78.3090701@student.ltu.se> (raw)
In-Reply-To: <200712022049.33601.hverkuil@xs4all.nl>
Hans Verkuil wrote:
> On Sunday 02 December 2007 18:46, Richard Knutsson wrote:
>
>> Fix "warning: Using plain integer as NULL pointer".
>>
>
> Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
>
>
>> Remove a gcc-2.95 requirement.
>>
>
> NACK! The main v4l-dvb repository that contains this driver can also be
> compiled on older systems. I'd like to keep the option that the driver
> can be compiled with an older gcc version, unless Mauro thinks
> otherwise. Other than the removal of one comment and one space there
> are no other benefits of this change, so I'd prefer to keep it.
>
>
Oh alright, thought it was just a leftover since the support for the
2.95 ended.
Maybe add something to the text to let others know the status? (Since I
found it by doing a 'grep' for "gcc 2.95"'s...)
>> Convert 'x < y ? x : y' to use min() instead.
>>
>
> Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
>
> Thanks,
>
> Hans
>
>
Thanks for the fast turnaround
Richard
next prev parent reply other threads:[~2007-12-02 22:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 17:46 [PATCH 1/2] ivtv: Some general fixes Richard Knutsson
2007-12-02 17:47 ` [PATCH 2/2] ivtv: Remove a invalid shadow-variable Richard Knutsson
2007-12-02 19:43 ` [v4l-dvb-maintainer] " Hans Verkuil
2007-12-02 19:49 ` [v4l-dvb-maintainer] [PATCH 1/2] ivtv: Some general fixes Hans Verkuil
2007-12-02 22:06 ` Richard Knutsson [this message]
2007-12-03 11:52 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47532C78.3090701@student.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.