From: Johannes Sixt <j.sixt@viscovery.net>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
A Large Angry SCM <gitzilla@gmail.com>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: make test failure with latest master
Date: Mon, 03 Dec 2007 08:33:27 +0100 [thread overview]
Message-ID: <4753B147.2050404@viscovery.net> (raw)
In-Reply-To: <20071203015954.GB8322@coredump.intra.peff.net>
Jeff King schrieb:
> -if ! ( type cvs && type cvsps ) >/dev/null 2>&1
> +if ! type cvs >/dev/null 2>&1
> then
> - test_expect_success 'skipping cvsimport tests, cvs/cvsps not found' ''
> + test_expect_success 'skipping cvsimport tests, cvs not found' ''
FWIW, the idiom to provide informative messages in test cases is
say 'skipping cvsimport tests, cvs not found'
This gives a distinguishing color, too.
-- Hannes
next prev parent reply other threads:[~2007-12-03 7:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 12:29 make test failure with latest master A Large Angry SCM
2007-12-02 12:52 ` Jakub Narebski
2007-12-02 14:01 ` A Large Angry SCM
2007-12-02 16:34 ` Jeff King
2007-12-02 23:19 ` A Large Angry SCM
2007-12-02 23:41 ` Johannes Schindelin
2007-12-03 1:59 ` Jeff King
2007-12-03 7:33 ` Johannes Sixt [this message]
2007-12-03 7:35 ` Jeff King
2007-12-03 23:10 ` A Large Angry SCM
2007-12-03 23:21 ` Junio C Hamano
2007-12-03 23:25 ` A Large Angry SCM
2007-12-04 1:41 ` [PATCH] t9600: require cvsps 2.1 to perform tests Jeff King
2007-12-04 5:37 ` Junio C Hamano
2007-12-04 15:44 ` Jeff King
2007-12-04 17:39 ` Junio C Hamano
2007-12-05 1:02 ` Jeff King
2007-12-05 5:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4753B147.2050404@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gitzilla@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.