From: Jeff Garzik <jeff@garzik.org>
To: Philip Langdale <philipl@overt.org>
Cc: Greg Freemyer <greg.freemyer@gmail.com>,
linux-ide@vger.kernel.org, Mark Lord <liml@rtr.ca>
Subject: Re: Enabling MSI in sata_nv
Date: Mon, 03 Dec 2007 14:16:15 -0500 [thread overview]
Message-ID: <475455FF.2060707@garzik.org> (raw)
In-Reply-To: <87f94c370712031055h4c359ee9w59fd076fedcc8b9f@mail.gmail.com>
Greg Freemyer wrote:
> On Dec 2, 2007 10:07 PM, Philip Langdale <philipl@overt.org> wrote:
>> Hi all,
>>
>> At least for my hardware (MCP55), the sata controller supports MSI
>> and it seems that turning it on is as simple as inserting the call
>> to pci_enable_msi - after that it Just Works(tm).
>>
>> Are there any gotchas that I'm missing? Would a patch to do this
>> be accepted?
>>
>> --phil
>
> I don't know if it is relevant, but I had to disable MSI to get a
> MCP55 NIC to work under 2.6.22.
MSI is pretty flaky, but we default it to 'on' for AHCI, which is the
"enhanced mode" side of the sata_nv chip.
So it is likely that it works on newer boards -- but even though Mark
Lord's response was mistaken (he thought sata_mv was being discussed),
he was right too... sata_nv has stability problems and I would prefer
not to enable MSI just yet, until we cure the other problems.
Jeff
next prev parent reply other threads:[~2007-12-03 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 3:07 Enabling MSI in sata_nv Philip Langdale
2007-12-03 17:28 ` Mark Lord
2007-12-03 17:57 ` Mark Lord
2007-12-03 19:17 ` Jeff Garzik
2007-12-03 18:55 ` Greg Freemyer
2007-12-03 19:16 ` Jeff Garzik [this message]
2007-12-04 1:56 ` Philip Langdale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475455FF.2060707@garzik.org \
--to=jeff@garzik.org \
--cc=greg.freemyer@gmail.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=philipl@overt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.