From: Daniel J Walsh <dwalsh@redhat.com>
To: Todd Miller <Tmiller@tresys.com>
Cc: Stephen Smalley <sds@tycho.nsa.gov>, SE Linux <selinux@tycho.nsa.gov>
Subject: Re: libsemanage patch
Date: Mon, 03 Dec 2007 15:08:41 -0500 [thread overview]
Message-ID: <47546249.5000606@redhat.com> (raw)
In-Reply-To: <6FE441CD9F0C0C479F2D88F959B0158801455C55@exchange.columbia.tresys.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Todd Miller wrote:
> Stephen Smalley wrote:
>> Given that getline() returns the length read (not to be confused with
>> the buffer length), why not just:
>> while ((len = getline(&temp, &buff_len, shells)) > 0) {
>> if (temp[len-1] == '\n') temp[len-1] = 0;
>
> That is probably the simplest fix.
>
> - todd
Fine with me, Do you want another patch.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFHVGJJrlYvE4MpobMRApYvAJ9IVdhR+SwUqZVdaTSayldB0LwQoACgyK4y
JovC/Zp6veX/jbP2m+qPbv0=
=5Azc
-----END PGP SIGNATURE-----
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2007-12-03 20:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 19:31 libsemanage patch Daniel J Walsh
2007-12-03 19:51 ` Todd Miller
2007-12-03 19:53 ` Stephen Smalley
2007-12-03 20:03 ` Todd Miller
2007-12-03 20:08 ` Daniel J Walsh [this message]
2007-12-03 20:49 ` Daniel J Walsh
2007-12-05 17:48 ` Stephen Smalley
-- strict thread matches above, loose matches on Subject: below --
2009-07-15 14:36 Daniel J Walsh
2009-08-11 21:22 ` Chad Sellers
2009-09-04 13:56 ` Joshua Brindle
2009-09-07 10:44 ` Daniel J Walsh
2009-09-08 16:04 ` Chad Sellers
2009-09-16 15:22 ` Joshua Brindle
2009-09-16 15:55 ` Joshua Brindle
2009-09-16 17:27 ` Daniel J Walsh
2009-09-16 21:12 ` Joshua Brindle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47546249.5000606@redhat.com \
--to=dwalsh@redhat.com \
--cc=Tmiller@tresys.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.