All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: [rfc] using xor in mark targets
Date: Tue, 04 Dec 2007 11:54:05 +0100	[thread overview]
Message-ID: <475531CD.5070604@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0712041145420.10859@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> On Dec 4 2007 10:17, Patrick McHardy wrote:
>> I still don't see why you can't keep --set-mark and add new options
>> --and-mark, --xor-mark, ...
>>
> 
> 	-j CONNMARK --xor-mark 0x01
> 	-j CONNMARK --and-mark 0xffffffdf
> 	-j CONNMARK --or-mark 0x400
> 
> I would prefer the single invocation:
> 
> 	-j CONNMARK --set-xmark 0x401/0xfffffbdf
> 

I wouldn't, thats way less readable :) Feel free to add a xmark
(maybe --raw-mark?) option, but the other ones should still exist
and --set-mark should behave as currently.


  reply	other threads:[~2007-12-04 10:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29 22:50 [rfc] using xor in mark targets Jan Engelhardt
2007-11-29 23:27 ` Patrick McHardy
2007-12-03 15:03   ` Jan Engelhardt
2007-12-03 15:09     ` Patrick McHardy
2007-12-03 17:35       ` Jan Engelhardt
2007-12-04  8:11         ` Patrick McHardy
2007-12-04  8:54           ` Jan Engelhardt
2007-12-04  9:17             ` Patrick McHardy
2007-12-04 10:52               ` Jan Engelhardt
2007-12-04 10:54                 ` Patrick McHardy [this message]
2007-12-04 14:05                   ` Jan Engelhardt
2007-12-04 14:08                     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=475531CD.5070604@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@computergmbh.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.