All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>,
	Samuel Thibault <samuel.thibault@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: Linux questions
Date: Tue, 04 Dec 2007 10:23:16 +0000	[thread overview]
Message-ID: <475538A4.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C379FC38.1951F%Keir.Fraser@cl.cam.ac.uk>

>>> Keir Fraser <Keir.Fraser@cl.cam.ac.uk> 03.12.07 19:32 >>>
>On 3/12/07 11:40, "Jan Beulich" <jbeulich@novell.com> wrote:
>
>>> rmb() is more powerful than barrier(), not the converse.
>> 
>> Oh, sorry, I mixed barrier() with mb(). So the proposal would then simply
>> be the other way around (the use of locked operations or fence instructions
>> on x86 is really unnecessary as long as WC memory or non-temporal stores
>> don't need to be taken into consideration).
>
>Then the implementation of rmb() should be equivalent to barrier(). The code
>in time-xen.c is implemented to the interface definitions of barrier() and
>rmb() -- the former is used just where instruction ordering is important;
>the latter where dynamic execution order matters too.

I have to disagree: At least the uses of barrier() in monotonic_clock() appear
to be in places where in reality (and from a theoretical standpoint) rmb()
ought to be used.

But I agree that rmb() (and also wmb()) on x86 doesn't need to be more
than barrier() (except, as said, in the context of WC memory or non-temporal 
memory accesses) - isn't that exactly what you just recently did in the
hypervisor?

Jan

  reply	other threads:[~2007-12-04 10:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-03 11:24 Linux questions Jan Beulich
2007-12-03 11:29 ` Samuel Thibault
2007-12-03 11:40   ` Jan Beulich
2007-12-03 18:32     ` Keir Fraser
2007-12-04 10:23       ` Jan Beulich [this message]
2007-12-04 10:55         ` Keir Fraser
2007-12-04 11:13           ` Andi Kleen
2007-12-04 11:27             ` Keir Fraser
2007-12-04 11:44               ` Andi Kleen
2007-12-04 11:56                 ` Keir Fraser
2007-12-04 12:23                   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=475538A4.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=samuel.thibault@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.