From: Jeff Garzik <jeff@garzik.org>
To: Robert Hancock <hancockr@shaw.ca>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
ide <linux-ide@vger.kernel.org>, Tejun Heo <htejun@gmail.com>,
Peer Chen <pchen@nvidia.com>, Kuan Luo <kluo@nvidia.com>,
Allen Martin <AMartin@nvidia.com>
Subject: Re: [PATCH] sata_nv: don't use legacy DMA in ADMA mode (v3)
Date: Tue, 04 Dec 2007 14:02:34 -0500 [thread overview]
Message-ID: <4755A44A.90003@garzik.org> (raw)
In-Reply-To: <4749FE58.4060800@shaw.ca>
Robert Hancock wrote:
> We need to run any DMA command with result taskfile requested in ADMA mode
> when the port is in ADMA mode, otherwise it may try to use the legacy DMA engine
> in ADMA mode which is not allowed. Enforce this with BUG_ON() since data
> corruption could potentially result if this happened. Also, fail any attempt to
> try and issue NCQ commands with result taskfile requested, since the hardware
> doesn't allow this.
>
> Signed-off-by: Robert Hancock <hancockr@shaw.ca>
applied #upstream-fixes
Please make sure to copy relevant NVIDIA engineers on your patches,
since they are actively contributing patches to Linux too (and, well,
its their hardware :))
Jeff
prev parent reply other threads:[~2007-12-04 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-25 22:59 [PATCH] sata_nv: don't use legacy DMA in ADMA mode (v3) Robert Hancock
2007-11-26 2:20 ` Tejun Heo
2007-12-04 19:02 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4755A44A.90003@garzik.org \
--to=jeff@garzik.org \
--cc=AMartin@nvidia.com \
--cc=hancockr@shaw.ca \
--cc=htejun@gmail.com \
--cc=kluo@nvidia.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pchen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.