From: Lachlan McIlroy <lachlan@sgi.com>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: Fix xfs_ichgtime mainline breakage.
Date: Wed, 05 Dec 2007 13:32:04 +1100 [thread overview]
Message-ID: <47560DA4.4090605@sgi.com> (raw)
In-Reply-To: <20071203074345.GW119954183@sgi.com>
Looks good Dave. Thanks for catching that.
David Chinner wrote:
> Folks,
>
> Just noticed with the mainline merge (2.6.24-rc3) to xfs-dev that
> xfs_ichgtime + xfs_ichgtime_fast are broken.
>
> if (!(inode->i_state & I_SYNC))
> mark_inode_dirty_sync(inode);
>
> that check used to be against I_LOCK, which was arguably broken,
> but this one will mean newly created files are not put on the dirty
> list and hence not written back by pdflush.
>
> Patch to fix this attached.
>
> Cheers,
>
> Dave.
prev parent reply other threads:[~2007-12-05 2:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 7:43 Fix xfs_ichgtime mainline breakage David Chinner
2007-12-05 2:32 ` Lachlan McIlroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47560DA4.4090605@sgi.com \
--to=lachlan@sgi.com \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.