All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: KVM: Export include/linux/kvm.h only if	$ARCH	actually supports KVM
Date: Wed, 05 Dec 2007 12:25:50 +0200	[thread overview]
Message-ID: <47567CAE.30301@qumranet.com> (raw)
In-Reply-To: <fj4gfd$g3n$1@ger.gmane.org>

Hollis Blanchard wrote:
>>  
>> diff --git a/drivers/kvm/Kconfig b/drivers/kvm/Kconfig index
>> 6569206..4086080 100644
>> --- a/drivers/kvm/Kconfig
>> +++ b/drivers/kvm/Kconfig
>> @@ -3,7 +3,7 @@
>>  #
>>  menuconfig VIRTUALIZATION
>>  	bool "Virtualization"
>> -	depends on X86
>> +	depends on ARCH_SUPPORTS_KVM || X86
>>  	default y
> I think this approach is fine, but don't forget that lguest was snuck 
> into drivers/kvm/Kconfig. 

Actually I considered this. X86 in the depends statement above is short 
for "ARCH_SUPPORTS_LGUEST"; otherwise it is not needed.


> It might be a good idea to move 
> CONFIG_VIRTUALIZATION into drivers/Kconfig at this point

I prefer a top-level virt/ and arch/*/virt/.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4

  reply	other threads:[~2007-12-05 10:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071202085006.C6D5A2508F6@il.qumranet.com>
     [not found] ` <20071202085006.C6D5A2508F6-LjA0eNSCdXrQnzwC+xcbyw@public.gmane.org>
2007-12-04 21:22   ` KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM Hollis Blanchard
2007-12-05 10:25     ` Avi Kivity [this message]
2008-02-10 11:15 Olaf Hering
2008-02-13  7:43 ` Avi Kivity
2008-02-13 20:34   ` Sam Ravnborg
2008-02-14  9:27     ` Avi Kivity
2008-03-13 11:13       ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47567CAE.30301@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.