All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eliot Blennerhassett <linux@audioscience.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Greg KH <greg@kroah.com>, alsa-devel@alsa-project.org
Subject: Re: asihpi driver -> kernel
Date: Fri, 07 Dec 2007 12:33:23 +1300	[thread overview]
Message-ID: <475886C3.9070301@audioscience.com> (raw)
In-Reply-To: <47397615.4000201@audioscience.com>

Eliot Blennerhassett wrote:
> Working on it, will submit new patches in the next week or so.

Hi Takashi,

I have been beating our code with a big stick for the last 4 weeks.

I'd appreciate any comment you have on the progress.



You can see the result here:
http://audioscience.com/internet/download/beta/alsahg3459_asihpi30905.tar.gz

The matching firmware is here:
http://audioscience.com/internet/download/beta/dspbins30905.tar.bz2

Note that dsp6413.bin is replaced by dsp6400.bin, dsp8713 by dsp8700.
You can remove all the dsp*.txt from the repo they are not needed.  Also
remove dsp2400, its not relevant.


The code is copmplete files rather than diffs, there are so many diffs I
don't think it is useful.  Apart from cosmetic changes, there are some
added and removed files compared to curren ALSA Hg repo:

* Merged all files relating to HPI4000 into hpi4000.[ch] (remove
hpi56301.[ch], boot4ka.h, dpi56301.h
* Removed hpicheck.h
* add hpimsginit.[ch] (no new functions)


Cosmetic changes
* Code is mostly 'checkpatch clean', though still some real work to do
around our use of volatile for structures that are updated by DMA by our
adapters

* Only 2 'sparse' warnings

* Got rid of nearly all typedefs, and most thin wrappers around kernel
functions.

* hpifunc.c now has no comments.  They might return when we get around
to grinding them all down to 80 columns...
Extracted documentation is available here in the mean time:
http://audioscience.com/internet/download/sdk/hpi_usermanual_html/html/index.html

regards

Eliot Blennerhassett
AudioScience Inc.

  reply	other threads:[~2007-12-06 23:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200709051300.35503.linux@audioscience.com>
     [not found] ` <s5hzm01tn8w.wl%tiwai@suse.de>
     [not found]   ` <47141823.4000307@audioscience.com>
2007-10-23 12:16     ` asihpi driver -> kernel Takashi Iwai
2007-11-13 10:01       ` Eliot Blennerhassett
2007-12-06 23:33         ` Eliot Blennerhassett [this message]
2007-12-13 15:16           ` Takashi Iwai
2007-12-14 16:09           ` Takashi Iwai
2007-12-18  0:16             ` Eliot Blennerhassett
2007-12-18 12:57               ` Takashi Iwai
2007-12-18 20:52                 ` Eliot Blennerhassett
2007-12-19 13:33                   ` Takashi Iwai
2007-12-19 20:42                     ` Eliot Blennerhassett
2007-12-18 22:13                 ` Eliot Blennerhassett
2007-12-19 13:36                   ` Takashi Iwai
2007-12-20  4:09                     ` [OT] visible symbols was " Eliot Blennerhassett
2007-12-20 11:14                       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=475886C3.9070301@audioscience.com \
    --to=linux@audioscience.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=greg@kroah.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.