All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Drake <dsd@gentoo.org>
To: Michael Buesch <mb@bu3sch.de>
Cc: David Miller <davem@davemloft.net>,
	jt@hpl.hp.com, shaddy_baddah@hotmail.com,
	linux-wireless@vger.kernel.org, johannes@sipsolutions.net
Subject: Re: zd1211rw (2.6.22 sparc64): unaligned access (do_rx)
Date: Fri, 07 Dec 2007 14:48:46 +0000	[thread overview]
Message-ID: <47595D4E.6080901@gentoo.org> (raw)
In-Reply-To: <200712071436.08954.mb@bu3sch.de>

Michael Buesch wrote:
> The wire protocol for the iv files is the following structure:
> 
> struct b43_iv {
> 	be16 a;
> 	union {
> 		be16 x;
> 		be32 y;
> 	} ((attr_packed));
> } ((attr_packed));
> 
> How do I handle that in userspace? In kernel space it's simple
> (and we already use get_unaligned() for the 32bit value there).

Please correct me if I'm wrong, but adding the "packed" attribute causes 
gcc to generate extra instructions to avoid the potentially unaligned 
accesses.
(i.e. it basically does put_aligned/get_unaligned automatically)

Daniel

  reply	other threads:[~2007-12-07 14:48 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-19  0:56 zd1211rw (2.6.22 sparc64): unaligned access (do_rx) Shaddy Baddah
2007-11-19  8:27 ` David Miller
2007-11-19 12:11   ` Shaddy Baddah
2007-11-19 12:19     ` David Miller
2007-11-21 13:08     ` Shaddy Baddah
2007-11-19 15:03   ` Johannes Berg
2007-11-19 18:04     ` Jean Tourrilhes
2007-11-21 13:18       ` Shaddy Baddah
2007-11-21 13:30         ` Shaddy Baddah
2007-11-21 14:23           ` Daniel Drake
2007-11-21 18:05             ` Kyle McMartin
2007-11-30  5:31             ` Shaddy Baddah
2007-11-21 14:33           ` Daniel Drake
2007-11-21 18:44         ` Jean Tourrilhes
2007-11-30  3:42           ` Shaddy Baddah
2007-11-30 20:21             ` Jean Tourrilhes
2007-12-04  0:01               ` Jean Tourrilhes
     [not found]                 ` <4756AABC.3000204@hotmail.com>
     [not found]                   ` <20071205215600.GA28349@bougret.hpl.hp.com>
2007-12-05 23:25                     ` Shaddy Baddah
2007-12-05 23:40                       ` Jean Tourrilhes
2007-12-06 21:59                       ` Jean Tourrilhes
2007-12-06  2:36                     ` David Miller
2007-12-06 21:25                       ` Jean Tourrilhes
2007-12-06 21:33                         ` Michael Buesch
2007-12-06 21:43                           ` Jean Tourrilhes
2007-12-07  3:52                             ` David Miller
2007-12-07 11:35                               ` Michael Buesch
2007-12-07 12:34                                 ` David Miller
2007-12-07 13:36                                   ` Michael Buesch
2007-12-07 14:48                                     ` Daniel Drake [this message]
2007-12-08  1:36                                       ` David Miller
2007-12-08  1:35                                     ` David Miller
2007-12-08 11:21                                       ` Michael Buesch
2007-12-08 12:54                                         ` Daniel Drake
2007-12-07  3:50                           ` David Miller
2007-12-07  3:49                         ` David Miller
2007-11-19 22:20     ` David Miller
2007-11-19 22:35       ` Jean Tourrilhes
2007-11-20  7:42         ` David Miller
2007-11-20 17:43           ` Jean Tourrilhes
2007-11-20 21:56             ` David Miller
2007-11-20 12:40       ` Johannes Berg
2007-11-20 12:46         ` David Miller
     [not found]           ` <20071120180016.GC1480@bougret.hpl.hp.com>
2007-11-20 21:58             ` David Miller
2007-11-20 22:08               ` John W. Linville
2007-11-20 22:38                 ` David Miller
2007-11-20 22:16               ` Jean Tourrilhes
2007-11-20 22:41                 ` David Miller
     [not found]             ` <20071120180601.GA2019@bougret.hpl.hp.com>
     [not found]               ` <47443430.3010504@hotmail.com>
2007-11-21 19:06                 ` Jean Tourrilhes
2007-11-20 17:38         ` Jean Tourrilhes
2007-11-20 12:34   ` David Miller
2007-11-20 13:15     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47595D4E.6080901@gentoo.org \
    --to=dsd@gentoo.org \
    --cc=davem@davemloft.net \
    --cc=johannes@sipsolutions.net \
    --cc=jt@hpl.hp.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mb@bu3sch.de \
    --cc=shaddy_baddah@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.