From: Jeff Garzik <jgarzik@pobox.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: netdev@vger.kernel.org, Wagner Ferenc <wferi@niif.hu>
Subject: Re: [PATCH 1/8] bonding: Remove trailing NULs from sysfs interface.
Date: Fri, 07 Dec 2007 15:02:13 -0500 [thread overview]
Message-ID: <4759A6C5.7040701@pobox.com> (raw)
In-Reply-To: <11970132363756-git-send-email-fubar@us.ibm.com>
Jay Vosburgh wrote:
> From: Wagner Ferenc <wferi@niif.hu>
>
> From: Wagner Ferenc <wferi@niif.hu>
>
> Also remove trailing spaces from multivalued files.
>
> This fixes output like for example:
>
> $ od -c /sys/class/net/bond0/bonding/slaves
> 0000000 e t h - l e f t e t h - r i g
> 0000020 h t \n \0
> 0000025
>
> It mostly entails deleting '+1'-s after sprintf() calls: the return value
> of sprintf is the number of characters printed, without the closing NUL,
> ie. exactly what the sysfs interface requires. The three multivalue
> cases are different, because they also have to swallow back a trailing
> space.
>
> Signed-off-by: Ferenc Wagner <wferi@niif.hu>
> Acked-by: Jay Vosburgh <fubar@us.ibm.com>
> ---
> drivers/net/bonding/bond_sysfs.c | 66 +++++++++++++++++--------------------
> 1 files changed, 30 insertions(+), 36 deletions(-)
applied 1-8 to #upstream-fixes
Your script is duplicating the "From: " line twice
prev parent reply other threads:[~2007-12-07 20:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-07 7:40 [PATCH 0/8] bonding: Several fixes, new hash mode Jay Vosburgh
2007-12-07 7:40 ` [PATCH 1/8] bonding: Remove trailing NULs from sysfs interface Jay Vosburgh
2007-12-07 7:40 ` [PATCH 2/8] bonding: Return nothing for not applicable values Jay Vosburgh
2007-12-07 7:40 ` [PATCH 3/8] bonding: Purely cosmetic: rename a local variable Jay Vosburgh
2007-12-07 7:40 ` [PATCH 4/8] bonding: Coding style: break line after the if condition Jay Vosburgh
2007-12-07 7:40 ` [PATCH 5/8] bonding: Allow setting and querying xmit policy regardless of mode Jay Vosburgh
2007-12-07 7:40 ` [PATCH 6/8] bonding: Fix time comparison Jay Vosburgh
2007-12-07 7:40 ` [PATCH 7/8] bonding: Add new layer2+3 hash for xor/802.3ad modes Jay Vosburgh
2007-12-07 7:40 ` [PATCH 8/8] bonding: Fix race at module unload Jay Vosburgh
2007-12-07 20:02 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4759A6C5.7040701@pobox.com \
--to=jgarzik@pobox.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=wferi@niif.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.