From: Timur Tabi <timur@freescale.com>
To: Poonam_Aggrwal-b10812 <b10812@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/3] arch/ : Platform changes for UCC TDM driver for MPC8323ERDB.Also includes related QE changes.
Date: Mon, 10 Dec 2007 12:48:01 -0600 [thread overview]
Message-ID: <475D89E1.4040107@freescale.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0712101734490.29623@linux121>
Poonam_Aggrwal-b10812 wrote:
> + qe = of_find_node_by_type(NULL, "qe");
> + if (qe) {
> + unsigned int size;
> + prop = of_get_property
> + (qe, "brg-frequency", &size);
> + of_node_put(qe);
> + of_node_put(brg);
> + return *prop;
> + }
Only very recent versions of U-Boot set the brg-frequency property, so you need
to check for situations where "*prop" is 0. If it is, then you need to take the
QE's bus-frequency property and divide it by two. See my ucc_uart driver for an
example.
And PowerPC-specific patches should not be cross-posted to linux-kernel.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2007-12-10 18:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-10 12:09 [PATCH 2/3] arch/ : Platform changes for UCC TDM driver for MPC8323ERDB.Also includes related QE changes Poonam_Aggrwal-b10812
2007-12-10 12:09 ` Poonam_Aggrwal-b10812
2007-12-10 18:48 ` Timur Tabi [this message]
2007-12-17 5:40 ` Poonam Aggrwal
2007-12-11 0:18 ` Stephen Rothwell
2007-12-11 0:18 ` Stephen Rothwell
2007-12-17 5:54 ` Aggrwal Poonam
2007-12-17 5:54 ` Aggrwal Poonam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475D89E1.4040107@freescale.com \
--to=timur@freescale.com \
--cc=b10812@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.