All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <larry.finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: Bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [RFC/T V2] b43: Fix rfkill radio LED
Date: Mon, 10 Dec 2007 11:22:22 -0800	[thread overview]
Message-ID: <475D91EE.6050909@lwfinger.net> (raw)
In-Reply-To: <200712101916.14311.mb@bu3sch.de>

Michael Buesch wrote:
> 
> I think that's not acceptable, as it introduces a nasty (although unlikely)
> race condition with the band switch. I will think about it and will fix
> it myself then. If there's no way to properly fix it, I think it may also
> be OK to live with this damn unlikely race.
> 
> Please also add the call to request_module() into the rfkill init and test
> if it works properly. After that, please send the complete patch back to me
> and I will try to fix the locking issue.

The request_module() call is in the version I just sent you. If rfkill-input is a module, it loads
correctly. If the code is built-in or if the code was not built at al, it generates an error;
therefore, my error message is a little ambiguous. If I use the CONFIG variables, I could generate
really proper messages, but I decided to skip that part.

Larry


      reply	other threads:[~2007-12-10 19:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-10 17:23 [RFC/T V2] b43: Fix rfkill radio LED Larry Finger
2007-12-10 18:16 ` Michael Buesch
2007-12-10 19:22   ` Larry Finger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=475D91EE.6050909@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=Bcm43xx-dev@lists.berlios.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mb@bu3sch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.