Re: [Qemu-devel] Re: [PATCH] mark host pages as reserved

[Fabrice Bellard <fabrice@bellard.org>]

Magnus Damm wrote:
> Hi everyone,
> 
> On Dec 5, 2007 5:45 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> Hi all,
>>
>> This patch teaches the user space emulator about host pages. It marks
>> present host page mappings with PAGE_RESERVED so mmap_find_vma()
>> properly can detect that pages at mmap_next_start should be skipped
>> over instead of being overwritten using mmap(). Without this patch I
>> experience crashes with the arm or sh4 user space emulator together
>> with sbox2. This combination sometimes result in that host libraries
>> are mapped into the qemu process space starting from 0x4xxxxxxx
>> instead of 0xb7xxxxxx. This together with the initial value of
>> mmap_next_start results in a segfault when the elf loader overwrites
>> the mapped host libraries with the target binary.
>>
>> Comments anyone?
> 
> Any reason for not applying this patch? This fixes user space
> emulation for all targets.

It seems OK.

Fabrice.