From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH 14/20] ide: convert "empty" REQ_TYPE_ATA_CMD requests to use REQ_TYPE_ATA_TASKFILE
Date: Thu, 13 Dec 2007 15:55:10 +0300 [thread overview]
Message-ID: <47612BAE.5030109@ru.mvista.com> (raw)
In-Reply-To: <200712092217.32139.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> Based on the previous work by Tejun Heo.
> There should be no functionality changes caused by this patch.
I didn't get the point. Why do you consider them "empty"?
> Cc: Tejun Heo <htejun@gmail.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Index: b/drivers/ide/ide-disk.c
> ===================================================================
> --- a/drivers/ide/ide-disk.c
> +++ b/drivers/ide/ide-disk.c
> @@ -620,8 +620,10 @@ static int set_multcount(ide_drive_t *dr
>
> if (drive->special.b.set_multmode)
> return -EBUSY;
> +
> ide_init_drive_cmd (&rq);
> - rq.cmd_type = REQ_TYPE_ATA_CMD;
> + rq.cmd_type = REQ_TYPE_ATA_TASKFILE;
> +
> drive->mult_req = arg;
> drive->special.b.set_multmode = 1;
> (void) ide_do_drive_cmd (drive, &rq, ide_wait);
> Index: b/drivers/ide/ide-taskfile.c
> ===================================================================
> --- a/drivers/ide/ide-taskfile.c
> +++ b/drivers/ide/ide-taskfile.c
> @@ -782,7 +782,7 @@ int ide_cmd_ioctl (ide_drive_t *drive, u
> struct request rq;
>
> ide_init_drive_cmd(&rq);
> - rq.cmd_type = REQ_TYPE_ATA_CMD;
> + rq.cmd_type = REQ_TYPE_ATA_TASKFILE;
>
> return ide_do_drive_cmd(drive, &rq, ide_wait);
> }
> Index: b/drivers/ide/ide.c
> ===================================================================
> --- a/drivers/ide/ide.c
> +++ b/drivers/ide/ide.c
> @@ -876,7 +876,7 @@ int set_pio_mode(ide_drive_t *drive, int
> return -EBUSY;
>
> ide_init_drive_cmd(&rq);
> - rq.cmd_type = REQ_TYPE_ATA_CMD;
> + rq.cmd_type = REQ_TYPE_ATA_TASKFILE;
>
> drive->tune_req = (u8) arg;
> drive->special.b.set_tune = 1;
MBR, Sergei
next prev parent reply other threads:[~2007-12-13 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-09 21:17 [PATCH 14/20] ide: convert "empty" REQ_TYPE_ATA_CMD requests to use REQ_TYPE_ATA_TASKFILE Bartlomiej Zolnierkiewicz
2007-12-13 12:55 ` Sergei Shtylyov [this message]
2007-12-13 13:54 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47612BAE.5030109@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.