Re: [PATCH][5/22] kvm portability: Moving apic and apic_base to kvm_vcpu arch.

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Zhang, Xiantao wrote:
> From: Zhang Xiantao <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Date: Fri, 14 Dec 2007 00:33:56 +0800
> Subject: [PATCH] kvm portability: Moving apic and apic_base to kvm_vcpu
> arch.
>
> This patches moving apic and apic_base to kvm_vcpu_arch.
> And use a macro apic(v) to simplifily get apic from vcpu.
>   

>  #define REG_POS(v) (((v) >> 5) << 4)
> +
> +#define apic(v) ((v)->arch.apic)
> +
>   

Using a macro called apic to reference a variable called apic is 
confusing.  I'll undo it, no need to resubmit.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace