Re: [PATCH 1/4] x86: clean up asm-x86/page*.h

[Jeremy Fitzhardinge <jeremy@goop.org>]

Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>   
>> Unify common definitions in page*.h.  To simplify other code, I added 
>> typedefs for the value of pte/pmd/pud/pgd values, so they can be used 
>> symbolically elsewhere without needing to have lots of 32/64/PAE 
>> tests.
>>
>> Also, add PAGETABLE_LEVELS define so that other definitions can test 
>> for it directly rather than using indirect 32/64/PAE tests.
>>     
>
> this one introduces mass warnings of:
>
>  include/asm/page.h: In function 'copy_page':
>  include/asm/page.h:34: warning: passing argument 2 of 'mmx_copy_page' discards qualifiers from pointer target type
>  In file included from include/asm/thread_info_32.h:14,
>                  from include/asm/thread_info.h:3,
>                  from include/linux/thread_info.h:35,
>                  from include/linux/preempt.h:10,
>                  from include/linux/spinlock.h:50,
>                  from include/linux/mmzone.h:8,
>                  from include/linux/gfp.h:5,
>                  from include/linux/mm.h:9,
>                  from arch/x86/mm/mmap.c:29:
>
> with the attached config.
>   

Hm.  I constified the "from" argument to copy_page on the way through
(to catch param-swapping problems).  Looks like I need to update
mmx_copy_page etc as well.  Anyway, this warning is harmless, and I'll
generate a separate patch to fix it.

    J