From: "Michael Kühn" <breiteseite1337@googlemail.com>
To: Mark Lord <lkml@rtr.ca>
Cc: linux-ide@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH] drivers/ata/ahci.c, kernel 2.6.23.10
Date: Sat, 15 Dec 2007 18:08:40 +0100 [thread overview]
Message-ID: <47640A18.4010308@googlemail.com> (raw)
In-Reply-To: <476404BD.5090801@rtr.ca>
Hmm...
but why we shouldn't integrate this fix in 2.6.23* branch?
I thought 2.6.23 and 2.6.24 are indepented from each other and get their
own fixes. So it's just a nice have-to-be in the next Bugfix release.
Yours sincerly
Michael Kühn
Mark Lord schrieb:
> Michael Kühn wrote:
>> This patch remove a unused variable in the ahci_port_intr function and
>> therewith a compiler warning.
>>
>> Signed-off-by: Michael Kühn <breiteseite1337@googlemail.com>
>>
>>
>> --- linux-2.6.23.10/drivers/ata/ahci.c 2007-12-14 19:01:59.000000000
>> +0100
>> +++ linux-2.6.23.10.new/drivers/ata/ahci.c 2007-12-15
>> 01:03:41.000000000 +0100
>> @@ -1430,7 +1430,6 @@
>> {
>> void __iomem *port_mmio = ap->ioaddr.cmd_addr;
>> struct ata_eh_info *ehi = &ap->eh_info;
>> - struct ahci_port_priv *pp = ap->private_data;
>> u32 status, qc_active;
>> int rc;
> ..
>
> Mmmm.. seems to not be applicable to current 2.6.24-rc*,
> as the "pp" variable *is* used in that function there.
>
> For older kernels, only serious bugs warrant an update.
>
> Cheers
next prev parent reply other threads:[~2007-12-15 17:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-15 15:31 [PATCH] drivers/ata/ahci.c, kernel 2.6.23.10 Michael Kühn
2007-12-15 16:45 ` Mark Lord
2007-12-15 17:08 ` Michael Kühn [this message]
2007-12-15 17:19 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47640A18.4010308@googlemail.com \
--to=breiteseite1337@googlemail.com \
--cc=linux-ide@vger.kernel.org \
--cc=lkml@rtr.ca \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.