All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	Netfilter Developer Mailing List
	<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 4/7] xt_mark match rev 1
Date: Mon, 17 Dec 2007 13:49:27 +0100	[thread overview]
Message-ID: <47667057.20303@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0712152219110.22877@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> On Dec 15 2007 17:42, Pablo Neira Ayuso wrote:
>
>> Netlink doesn't stick us to fixed structure layouts as it happens to the
>> current interface since we represent the messages kernel <-> userspace
>> in TLV (type-length-value) format. Thus, userspace and kernel won't
>> share structures and new features just require a new type. For that
>> reason, the netlink interface won't require such revision infrastructure.
>>
> Please explain the TLV thing. How would something like
> struct ipt_tos_target_info (revision 0, in net-2.6.25/xt_DSCP.c) and
> struct xt_tos_target_info (revision 1, in net-2.6.25/xt_DSCP.c) be
> encoded?
> Does the mere presence of a TLV block (sending it over netlink) indicate
> a certain revision?


Since the kernel doesn't share structures with userspace anymore,
you can simply use the most generic form within the kernel and
put the userspace-data in the required form during initialization.

  reply	other threads:[~2007-12-17 12:50 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-07  2:35 [PATCH 1/7] Use %u format specifiers Jan Engelhardt
2007-12-07  2:36 ` [PATCH 2/7] Introduce nf_inet_address Jan Engelhardt
2007-12-11 10:16   ` Patrick McHardy
2007-12-15 12:06     ` Jan Engelhardt
2007-12-15 16:21       ` Jan Engelhardt
2007-12-17 12:52         ` Patrick McHardy
2007-12-17 12:28       ` Patrick McHardy
2007-12-17 12:51         ` Jan Engelhardt
2007-12-17 13:00           ` Patrick McHardy
2007-12-07  2:40 ` [PATCH 3/7] xt_connlimit rev 1 Jan Engelhardt
2007-12-11 10:19   ` Patrick McHardy
2007-12-15 12:20     ` [PATCH 3/7] Let xt_connlimit use nf_inet_addr Jan Engelhardt
2007-12-17 12:33       ` Patrick McHardy
2007-12-17 12:52         ` Jan Engelhardt
2007-12-17 12:54           ` Patrick McHardy
2007-12-07  2:41 ` [PATCH 4/7] xt_mark match rev 1 Jan Engelhardt
2007-12-11 10:25   ` Patrick McHardy
2007-12-15 12:28     ` Jan Engelhardt
2007-12-15 15:55       ` Pablo Neira Ayuso
2007-12-15 16:10         ` Jan Engelhardt
2007-12-15 16:42           ` Pablo Neira Ayuso
2007-12-15 21:26             ` Jan Engelhardt
2007-12-17 12:49               ` Patrick McHardy [this message]
2007-12-17 12:47             ` Patrick McHardy
2007-12-17 13:08               ` Pablo Neira Ayuso
2007-12-17 13:44                 ` Patrick McHardy
2007-12-17 12:37       ` Patrick McHardy
2007-12-17 12:55         ` Jan Engelhardt
2007-12-07  2:41 ` [PATCH 5/7] xt_MARK target rev 2 Jan Engelhardt
2007-12-11 10:27   ` Patrick McHardy
2007-12-15 13:59     ` Jan Engelhardt
2007-12-15 14:47       ` Jan Engelhardt
2007-12-07  2:42 ` [PATCH 6/7] xt_connmark rev 1 Jan Engelhardt
2007-12-07  2:42 ` [PATCH 7/7] xt_CONNMARK " Jan Engelhardt
2007-12-11 10:13 ` [PATCH 1/7] Use %u format specifiers Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47667057.20303@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@computergmbh.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.