From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 3/7] Let xt_connlimit use nf_inet_addr Date: Mon, 17 Dec 2007 13:54:50 +0100 Message-ID: <4766719A.8050406@trash.net> References: <475E6445.4090202@trash.net> <47666CA9.9070901@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Netfilter Developer Mailing List To: Jan Engelhardt Return-path: Received: from stinky.trash.net ([213.144.137.162]:56935 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752934AbXLQMzg (ORCPT ); Mon, 17 Dec 2007 07:55:36 -0500 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Jan Engelhardt wrote: > On Dec 17 2007 13:33, Patrick McHardy wrote: >> Jan Engelhardt wrote: >>> Make xt_connlimit use the new union nf_inet_addr. >> Applied, thanks. Could you make your subjects follow the >> naming convention for netfilter patches please? That >> would avoid the need to edit them every time I apply >> a patch: >> >> [NETFILTER]: xt_connlimit: use the new union nf_inet_addr > > Ok! > >> Somewhere in the email itself would also be fine. >> > That generally does not work :P - the git changelog then > has the same line twice. (Look at `git log > 67b4af297033f5f65999885542f95ba7b562848a` - there is twice > "Fix forgotten module release") Thats fine, I apply patches using stg import -m -e, so I go over them in an editor anyway (and can delete duplicate lines if I notice). Not having the edit the entire message is just a time saver :)