From: Patrick McHardy <kaber@trash.net>
To: Sami Farin <safari-netfilter@safari.iki.fi>
Cc: David Miller <davem@davemloft.net>,
dada1@cosmosbay.com, jarkao2@gmail.com,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [NETFILTER] xt_hashlimit : speedups hash_dst()
Date: Mon, 17 Dec 2007 15:15:48 +0100 [thread overview]
Message-ID: <47668494.3080708@trash.net> (raw)
In-Reply-To: <20071217140442.efbpwsc2uhqvnkfp@m.safari.iki.fi>
Sami Farin wrote:
> On Sat, Dec 15, 2007 at 21:42:19 -0800, David Miller wrote:
>> From: Eric Dumazet <dada1@cosmosbay.com>
>> Date: Sat, 15 Dec 2007 12:04:47 +0100
>>
>>> I prefer to let admins chose their size, since it makes attacker life more
>>> difficult :)
>>>
>>> For example, I can tell you I have a server, were size is between 2.000.000
>>> and 3.500.000, I dont want to be forced to use 2097152
>>>
>>> A multiply is cheap, at least on current hardware.
>> I agree, and I see nothing wrong with Eric's patch and it
>> should be merged ASAP.
>
> You could do the same optimization for
> net/netfilter/nf_conntrack_core.c:__hash_conntrack() , too.
Yes, I already took care of that for conntrack and other netfilter
non-power-of-two hashes.
next prev parent reply other threads:[~2007-12-17 14:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 11:09 [NETFILTER] xt_hashlimit : speedups hash_dst() Eric Dumazet
2007-12-14 11:20 ` Patrick McHardy
2007-12-14 18:30 ` David Miller
2007-12-14 20:59 ` Jarek Poplawski
2007-12-14 21:37 ` Eric Dumazet
2007-12-15 10:41 ` Jarek Poplawski
2007-12-15 11:04 ` Eric Dumazet
2007-12-16 5:42 ` David Miller
2007-12-17 12:38 ` Patrick McHardy
2007-12-17 14:04 ` Sami Farin
2007-12-17 14:15 ` Patrick McHardy [this message]
2007-12-14 21:40 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47668494.3080708@trash.net \
--to=kaber@trash.net \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=safari-netfilter@safari.iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.