From: Boaz Harrosh <bharrosh@panasas.com>
To: Olivier Galibert <galibert@pobox.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Filippos Papadopoulos <psybases@gmail.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: INITIO scsi driver fails to work properly
Date: Mon, 17 Dec 2007 19:00:26 +0200 [thread overview]
Message-ID: <4766AB2A.7000206@panasas.com> (raw)
In-Reply-To: <20071217162040.GB5056@dspnet.fr.eu.org>
On Mon, Dec 17 2007 at 18:20 +0200, Olivier Galibert <galibert@pobox.com> wrote:
> On Mon, Dec 17, 2007 at 06:08:59PM +0200, Boaz Harrosh wrote:
>> Below fixes a deadly typo. Might as well be included in 2.6.24
>
> You're sure ? scsi_for_each_sg includes a (sg)++ already...
>
>
>> scsi_for_each_sg(cmnd, sglist, cblk->sglen, i) {
>> sg->data = cpu_to_le32((u32)sg_dma_address(sglist));
>> total_len += sg->len = cpu_to_le32((u32)sg_dma_len(sglist));
>> + ++sg;
>> }
>
> OG.
> --
Don't mix up between the here sg that points to a driver specific struct sg_entry
and the here sglist which points to struct scatterlist, and is named sg inside
the scsi_for_each_sg() macro. Please inspect the full code, the patch does not
show the complete information. I admit it's confusing.
Boaz
next prev parent reply other threads:[~2007-12-17 17:01 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 9:39 INITIO scsi driver fails to work properly Filippos Papadopoulos
2007-12-17 11:18 ` Andrew Morton
2007-12-17 11:41 ` Filippos Papadopoulos
2007-12-17 12:18 ` Boaz Harrosh
2007-12-17 12:24 ` Boaz Harrosh
2007-12-19 8:48 ` Filippos Papadopoulos
2007-12-19 10:08 ` Boaz Harrosh
2007-12-19 13:29 ` Matthew Wilcox
2007-12-19 16:50 ` James Bottomley
2007-12-19 17:05 ` Matthew Wilcox
2007-12-20 9:32 ` Natalie Protasevich
2007-12-20 15:08 ` James Bottomley
2007-12-20 15:14 ` Theodore Tso
2007-12-21 19:30 ` Chuck Ebbert
2007-12-21 21:03 ` James Bottomley
2007-12-21 22:43 ` Chuck Ebbert
2007-12-21 22:49 ` James Bottomley
2008-01-04 0:18 ` Filippos Papadopoulos
2008-01-11 5:16 ` James Bottomley
2008-01-11 9:54 ` Filippos Papadopoulos
2008-01-11 15:44 ` James Bottomley
2008-01-11 16:44 ` Filippos Papadopoulos
2008-01-11 17:01 ` Alan Cox
2008-01-11 17:33 ` James Bottomley
2008-01-11 17:01 ` James Bottomley
2008-01-13 12:28 ` Filippos Papadopoulos
2008-01-15 15:16 ` James Bottomley
2008-01-16 5:59 ` FUJITA Tomonori
2008-01-16 14:57 ` James Bottomley
2008-01-21 22:20 ` Alan Cox
2008-01-22 17:50 ` Filippos Papadopoulos
2008-01-25 16:49 ` James Bottomley
2008-01-25 21:04 ` Filippos Papadopoulos
2008-01-11 17:52 ` Chuck Ebbert
2008-01-11 18:21 ` Alan Cox
2007-12-17 13:05 ` Alan Cox
2007-12-17 14:40 ` Boaz Harrosh
2007-12-17 14:36 ` Alan Cox
2007-12-17 15:03 ` James Bottomley
2007-12-17 16:08 ` Boaz Harrosh
2007-12-17 16:20 ` Olivier Galibert
2007-12-17 17:00 ` Boaz Harrosh [this message]
2007-12-17 16:13 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4766AB2A.7000206@panasas.com \
--to=bharrosh@panasas.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=galibert@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=psybases@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.