From: Roel Kluin <12o3l@tiscali.nl>
To: netdev@vger.kernel.org
Subject: [PATCH drivers/net/skfp/h/fplustm.h] parentheses around RX_FIFO_SPACE definition
Date: Mon, 17 Dec 2007 22:55:16 +0100 [thread overview]
Message-ID: <4766F044.8090302@tiscali.nl> (raw)
drivers/net/skfp/h/fplustm.h:129:
#define RX_FIFO_SPACE 0x4000 - RX_FIFO_OFF
drivers/net/skfp/fplustm.c:1404:
smc->hw.fp.fifo.rx1_fifo_size = RX_FIFO_SPACE *
SMT_R1_RXD_COUNT/(SMT_R1_RXD_COUNT+SMT_R2_RXD_COUNT) ;
smc->hw.fp.fifo.rx2_fifo_size = RX_FIFO_SPACE *
SMT_R2_RXD_COUNT/(SMT_R1_RXD_COUNT+SMT_R2_RXD_COUNT) ;
Add parentheses to definition to prevent operator precedence errors
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/net/skfp/h/fplustm.h b/drivers/net/skfp/h/fplustm.h
index 98bbf65..588579c 100644
--- a/drivers/net/skfp/h/fplustm.h
+++ b/drivers/net/skfp/h/fplustm.h
@@ -126,7 +126,7 @@ struct s_smt_rx_queue {
#define SYNC_TRAFFIC_ON 0x2
/* big FIFO memory */
-#define RX_FIFO_SPACE 0x4000 - RX_FIFO_OFF
+#define RX_FIFO_SPACE (0x4000 - RX_FIFO_OFF)
#define TX_FIFO_SPACE 0x4000
#define TX_SMALL_FIFO 0x0900
reply other threads:[~2007-12-17 21:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4766F044.8090302@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.