From: Jeff Garzik <jgarzik@pobox.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: mikep@linuxtr.net, netdev@vger.kernel.org, kaaker@brocade.com
Subject: Re: [PATCH] endianness annotations and fixes for olympic
Date: Mon, 17 Dec 2007 18:15:50 -0500 [thread overview]
Message-ID: <47670326.3010108@pobox.com> (raw)
In-Reply-To: <20071216205336.GW8181@ftp.linux.org.uk>
Al Viro wrote:
> * missing braces in !readl(...) & ...
> * trivial endianness annotations
> * in olympic_arb_cmd() the loop collecting fragments of
> packet is b0rken on big-endian - we have
> (next_ptr && (buf_ptr=olympic_priv->olympic_lap + ntohs(next_ptr)))
> as condition and it should have swab16(), not ntohs() - it's host-endian
> byteswapped, not big-endian. So if we get more than one fragment on big-endian
> host, we get screwed.
> This ntohs() got missed back when the rest of those had been switched
> to swab16() in 2.4.0-test2-pre1 - at a guess, nobody had hit fragmented
> packets during the testing of PPC fixes.
>
> PS: Ken Aaker cc'd on assumption that he is the same guy who'd done the
> original set of PPC fixes in olympic
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
applied #upstream
prev parent reply other threads:[~2007-12-17 23:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-16 20:53 [PATCH] endianness annotations and fixes for olympic Al Viro
2007-12-17 23:15 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47670326.3010108@pobox.com \
--to=jgarzik@pobox.com \
--cc=kaaker@brocade.com \
--cc=mikep@linuxtr.net \
--cc=netdev@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.